-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove argparse from get_client function signature #12
Conversation
Signed-off-by: Ryan Wolf <[email protected]>
@ryantwolf I think we should have this functionality. I was trying to use the Curator through a notebook and had to do some gymnastics to create a client using If this is too much work for now, maybe a simple workaround would be to have an equivalent of |
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryantwolf looks good to me.
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Main items:
get_client
function to not use argparseparse_client_args
function to bridge argparse to newget_client
get_client
invocationsget_client
to be imported from root module likefrom nemo_curator import get_client
Other changes:
find_exact_duplicates.py
determines whether to use CPU or GPU.