Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update PTL import #409

Closed
wants to merge 2 commits into from
Closed

Conversation

maanug-nv
Copy link
Collaborator

What does this PR do ?

See this PR for context.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

maanug-nv and others added 2 commits November 18, 2024 11:57
Signed-off-by: Maanu Grover <[email protected]>
for more information, see https://pre-commit.ci

Signed-off-by: NeMo-Aligner CI <[email protected]>
@github-actions github-actions bot added the Utils label Nov 18, 2024
@maanug-nv maanug-nv changed the title Update PTL import fix: Update PTL import Nov 18, 2024
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Nov 18, 2024
@maanug-nv maanug-nv changed the base branch from main to dev November 18, 2024 22:40
@maanug-nv maanug-nv changed the base branch from dev to main November 18, 2024 22:42
@terrykong
Copy link
Collaborator

close in favor of #410

@terrykong terrykong closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger Utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants