Use top_p=0.0 by default (instead of 1.0)
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we otherwise do useless computations, at least until
NVIDIA/NeMo#8905
is merged
Signed-off-by: Olivier Delalleau <[email protected]>
|
hm, I'm a bit hesitant to merge this because we're going to forget to revert it back again. Should we wait for your nemo PR to be merged and then cherrypick it into our dockerfile? |
We don't need to. |
ah I see. then yes this LGTM. it's less confusing this way |
|
could you also update the CHANGELOG to describe the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because we otherwise do useless computations, at least until
NVIDIA/NeMo#8905
is merged.