Skip to content

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 8, 2025

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • CI configuration updated so artifact upload now runs for release branches matching release/*.
    • Ensures build artifacts (wheels/uploads) are produced for release branches to improve availability for testing and distribution.
    • No changes to application behavior or UI.

@dagardner-nv dagardner-nv self-assigned this Oct 8, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 8, 2025 15:44
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025

Walkthrough

Updated GitLab CI to run the upload:artifactory job for branches matching release/* by adding a regex rule; corresponding CI script behavior was aligned to include release branches. No other jobs or settings changed.

Changes

Cohort / File(s) Summary
CI configuration
\.gitlab-ci.yml, ci/scripts/gitlab/build_wheel.sh
Added rule to trigger upload:artifactory on release branches: - if: $CI_COMMIT_BRANCH =~ /^release\/.*$/. The .gitlab-ci.yml job rules were updated and the wheel upload script behavior/triggering was extended to include release/* branches.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Dev as Developer
    participant GitLab as GitLab CI
    participant Job as upload:artifactory
    participant Script as build_wheel.sh

    Dev->>GitLab: Push commit
    GitLab->>GitLab: Evaluate job rules
    alt Branch matches /^release\/.*$/
        GitLab->>Job: Schedule upload:artifactory
        Job->>Script: Invoke wheel upload steps
        Script-->>Job: Upload actions complete
    else Other existing rule matched
        GitLab->>Job: Schedule upload:artifactory (existing condition)
        Job->>Script: Invoke wheel upload steps
        Script-->>Job: Upload actions complete
    else No rule matched
        GitLab--x Job: Not scheduled
    end

    Note over GitLab,Job: New regex rule enables job on release/* branches
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title uses imperative mood, is concise under the character limit, and clearly describes the main change of enabling the upload step for release branches in nightly builds. It accurately reflects the modifications to the CI configuration to include release/* branches in the upload job.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4607965 and 150f360.

📒 Files selected for processing (1)
  • ci/scripts/gitlab/build_wheel.sh (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
{scripts/**,ci/scripts/**}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Shell or utility scripts belong in scripts/ or ci/scripts/ and must not be mixed with library code

Files:

  • ci/scripts/gitlab/build_wheel.sh
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • ci/scripts/gitlab/build_wheel.sh
🔇 Additional comments (1)
ci/scripts/gitlab/build_wheel.sh (1)

62-76: Release branches included in upload guard

Thanks for extending the upload trigger to release/*; the glob matches as intended inside [[ … ]], so release branch builds now reach the Artifactory upload step without affecting other branches.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 148af34 into NVIDIA:release/1.3 Oct 8, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-fix-artifactory branch October 8, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants