Skip to content

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 7, 2025

Description

  • Enables running the examples/frameworks/haystack_deep_research_agent/tests/test_haystack_deep_research_agent.py integration test.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated CI pipeline to provision an OpenSearch service container (opensearchproject/opensearch:2.11.1) with single-node mode and security disabled for CI execution.
    • Added a CI environment variable for the OpenSearch endpoint (http://opensearch:9200).
    • These changes standardize the CI environment and improve consistency of pipeline runs involving search-related operations.

Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv self-assigned this Oct 7, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 7, 2025 21:10
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Oct 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025

Walkthrough

Added an OpenSearch service container to the GitLab CI configuration and defined a CI variable for its URL.

Changes

Cohort / File(s) Summary
CI configuration
\.gitlab-ci.yml
Added CI variable NAT_CI_OPENSEARCH_URL=http://opensearch:9200. Introduced OpenSearch service opensearchproject/opensearch:2.11.1 with alias opensearch and environment variables discovery.type=single-node, plugins.security.disabled=true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Add opensearch service to CI” is concise, uses the imperative mood, and accurately summarizes the main change of introducing an OpenSearch service into the CI pipeline for integration testing. It clearly reflects the pull request’s intent and stays well within the 72-character limit.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.gitlab-ci.yml (1)

98-102: Harden OpenSearch service: heap cap, readiness, and robust config delivery.

  • Add OPENSEARCH_JAVA_OPTS to reduce CI memory pressure.
  • Consider passing settings via command -E to avoid dotted env var quirks on some runners.
  • Ensure tests wait for OpenSearch readiness to prevent flakes.

Suggested minimal change (heap cap):

     - name: opensearchproject/opensearch:2.11.1
       alias: opensearch
       variables:
         discovery.type: "single-node"
         plugins.security.disabled: "true"
+        OPENSEARCH_JAVA_OPTS: "-Xms512m -Xmx512m"

Alternative (more robust) config via command:

-    - name: opensearchproject/opensearch:2.11.1
-      alias: opensearch
-      variables:
-        discovery.type: "single-node"
-        plugins.security.disabled: "true"
+    - name: opensearchproject/opensearch:2.11.1
+      alias: opensearch
+      command: ["opensearch", "-E", "discovery.type=single-node", "-E", "plugins.security.disabled=true"]
+      variables:
+        OPENSEARCH_JAVA_OPTS: "-Xms512m -Xmx512m"

Also verify the runner host doesn’t block OpenSearch on vm.max_map_count; if it does, we may need to retry with a lighter search backend for CI or use a runner with that sysctl set.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f1872e and 868de88.

📒 Files selected for processing (1)
  • .gitlab-ci.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: CI Pipeline / Check
🔇 Additional comments (1)
.gitlab-ci.yml (1)

45-45: Good addition; confirm consumers.

NAT_CI_OPENSEARCH_URL looks correct for intra-job networking. Please confirm tests/examples actually read this variable (or default to the same URL) to avoid flakiness.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c17732d into NVIDIA:release/1.3 Oct 7, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-opensearch-ci branch October 7, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants