-
Notifications
You must be signed in to change notification settings - Fork 423
Add opensearch service to CI #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opensearch service to CI #944
Conversation
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
WalkthroughAdded an OpenSearch service container to the GitLab CI configuration and defined a CI variable for its URL. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitlab-ci.yml (1)
98-102: Harden OpenSearch service: heap cap, readiness, and robust config delivery.
- Add OPENSEARCH_JAVA_OPTS to reduce CI memory pressure.
- Consider passing settings via command -E to avoid dotted env var quirks on some runners.
- Ensure tests wait for OpenSearch readiness to prevent flakes.
Suggested minimal change (heap cap):
- name: opensearchproject/opensearch:2.11.1 alias: opensearch variables: discovery.type: "single-node" plugins.security.disabled: "true" + OPENSEARCH_JAVA_OPTS: "-Xms512m -Xmx512m"Alternative (more robust) config via command:
- - name: opensearchproject/opensearch:2.11.1 - alias: opensearch - variables: - discovery.type: "single-node" - plugins.security.disabled: "true" + - name: opensearchproject/opensearch:2.11.1 + alias: opensearch + command: ["opensearch", "-E", "discovery.type=single-node", "-E", "plugins.security.disabled=true"] + variables: + OPENSEARCH_JAVA_OPTS: "-Xms512m -Xmx512m"Also verify the runner host doesn’t block OpenSearch on vm.max_map_count; if it does, we may need to retry with a lighter search backend for CI or use a runner with that sysctl set.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitlab-ci.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CI Pipeline / Check
🔇 Additional comments (1)
.gitlab-ci.yml (1)
45-45: Good addition; confirm consumers.NAT_CI_OPENSEARCH_URL looks correct for intra-job networking. Please confirm tests/examples actually read this variable (or default to the same URL) to avoid flakiness.
|
/merge |
Description
examples/frameworks/haystack_deep_research_agent/tests/test_haystack_deep_research_agent.pyintegration test.By Submitting this PR I confirm:
Summary by CodeRabbit