Skip to content

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Oct 6, 2025

Description

uvicorn versions 0.36 and higher run into runtime errors due to nest_asyncio's patching being out-of-date on Python >= 3.12

Pin uvicorn to a version that does not exhibit runtime errors

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated the server runtime dependency uvicorn[standard] version constraint from ~=0.34 to <0.36.
    • Standardizes supported versions to reduce unexpected behavior during upgrades and improve deployment reliability.
    • No changes to application features or user interface.
    • All other dependencies remain unchanged, keeping build performance and size consistent.

@willkill07 willkill07 requested review from a team as code owners October 6, 2025 22:45
@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Walkthrough

Updated uvicorn[standard] dependency constraint in pyproject.toml from ~=0.34 to <0.36 and added a comment noting the cap is temporary pending nest_asyncio resolution. No other files or dependencies changed.

Changes

Cohort / File(s) Summary
Dependency constraints
pyproject.toml
Constrain uvicorn[standard] to <0.36 (from ~=0.34); add temporary comment regarding nest_asyncio.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

bug

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the core change by stating the action (“pin uvicorn”) and its purpose (“to prevent nest_asyncio patch error”), uses the imperative mood, and stays well under the 72-character limit.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot added the bug Something isn't working label Oct 6, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6460b4b and 474fcc6.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • pyproject.toml

@dagardner-nv dagardner-nv added the non-breaking Non-breaking change label Oct 6, 2025
@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a69d117 into NVIDIA:release/1.3 Oct 6, 2025
17 checks passed
@willkill07 willkill07 deleted the wkk_pin-uvicorn-to-prevent-nest_asyncio-patch-error branch October 23, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants