-
Notifications
You must be signed in to change notification settings - Fork 416
Update MCP related CLI commands in cli.md
#903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MCP related CLI commands in cli.md
#903
Conversation
WalkthroughExpanded and restructured CLI documentation for MCP. Added a new Client subsection with detailed help for ping and tool (list/call). Enhanced Serve subsection with updated defaults, examples, and clarified descriptions. Adjusted examples to new host/port and endpoint. Applied minor formatting consistency updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… match (NVIDIA#893) Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * Documentation * Clarified MCP transport configuration in client workflow docs: when using Server-Sent Events (SSE), start the MCP server with the --transport sse flag, and ensure the client and server transport types match. Documented that the default transport is streamable-http, requiring an explicit override for SSE to ensure compatibility. This guidance is now included in the MCP client documentation. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Will Killian (https://github.com/willkill07) - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#893 Signed-off-by: Yuchen Zhang <[email protected]>
## Description <!-- Note: The pull request title will be included in the CHANGELOG. --> <!-- Provide a standalone description of changes in this PR. --> <!-- Reference any issues closed by this PR with "closes #1234". All PRs should have an issue they close--> Closes AIQ-1957 - Made the default workflow a react-based workflow - Used `python_safe_workflow_name` instead for the module name - Edited `workflow_commands.py` by replacing `workflow_name` with `package_name`, to ensure imports work (because `package_name` doesn't have `-`) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added an echo tool (configurable prefix) and a current_datetime tool to workflows. - Introduced a default NIM LLM using meta/llama-3.1-70b-instruct (temperature 0.0). - Workflows gain LangChain wrapper support and parse-agent response retry set to 3. - **Refactor** - Workflow templates now use a ReAct agent type and reference the NIM LLM and tools. - Generated workflow names/exports now use Python-safe naming conventions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Daniel Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Co-authored-by: Yuchen Zhang <[email protected]> Co-authored-by: Will Killian <[email protected]> Signed-off-by: Yuchen Zhang <[email protected]>
This PR significantly improves OpenAI Chat Completions API compatibility by fixing response format compliance, and removing unused code. The changes ensure that NAT's OpenAI-compatible endpoints fully adhere to the OpenAI specification for both streaming and non-streaming responses. Closes: NVIDIA#818 A follow-up issue has been created to address accurate calculation and passing of usage statistics from workflows to ChatResponse objects in OpenAI-compatible endpoints: [Issue: 891](NVIDIA#891). ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - New Features - All responses — including error replies — now include usage statistics (prompt, completion, total tokens). - Refactor - OpenAI-compatible non‑streaming path simplified to return a single JSON response; Content-Type set explicitly for JSON and streaming. - Default model identifier standardized to "unknown-model" in responses. - Compatibility - Streaming chunk roles standardized to an enum-style role; response payloads and tests now include and expect usage metadata. Authors: - Eric Evans II (https://github.com/ericevans-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: NVIDIA#889 Signed-off-by: Yuchen Zhang <[email protected]>
Enable optional token storage for MCP OAuth2 with in-memory or external object-store backends (e.g., S3/MinIO), which are persistent and also more secure. Also enabled users to implement their own external object-store interface. Closes AIQ-1965 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - New Features - Secure token storage for MCP OAuth2: in-memory default with optional external object-store backing, persistent across restarts, multi-user isolation, automatic refresh, and graceful fallback. - Documentation - Added “Secure Token Storage” guide with examples and deployment guidance; MCP auth docs and index updated to reference it. - Tests - Extensive tests covering token storage backends, key hashing/serialization, provider integration, lazy object-store resolution, and persistence. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#883 Signed-off-by: Yuchen Zhang <[email protected]>
Cleans up the default configuration + workflow template a little more ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - New Features - None - Refactor - Simplified generated workflow configuration by removing redundant logging and frontend blocks and a deprecated retry option. - Aligned workflow registration naming to a consistent convention. - Documentation - Added comprehensive docstrings to the workflow and helper to improve clarity and editor hints. - Chores - Cleaned up default config output to reduce noise and simplify generated templates. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#899 Signed-off-by: Yuchen Zhang <[email protected]>
Update the CLI tree based on features since 1.2 release Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Expanded CLI reference with new top-level groups: mcp (client, serve), object-store (mysql, redis, s3), and sizing (calc). * Reorganized structure: promoted sizing to top-level; removed nested serve/client subtree from Start workflow. * Adjusted Workflow ordering: “delete” now precedes “reinstall” under Reinstall/Delete. * Updated navigation and anchors for clarity and discoverability. * Content-only changes; no impact on command behavior. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#900 Signed-off-by: Yuchen Zhang <[email protected]>
## Description <!-- Note: The pull request title will be included in the CHANGELOG. --> <!-- Provide a standalone description of changes in this PR. --> <!-- Reference any issues closed by this PR with "closes #1234". All PRs should have an issue they close--> Closes 1897 **Added**: - `ContextState` fields: `workflow_run_id`, `workflow_trace_id` (`src/nat/builder/context.py`) - Non-zero ID generators & validators for OpenTelemetry-sized IDs (`src/nat/data_models/span.py`) - Workflow start/end event emission with metadata: `workflow_run_id`, `workflow_trace_id`, `conversation_id` (`src/nat/runtime/runner.py`) - Span attributes for correlation: `.workflow.run_id`, `.workflow.trace_id`, `.conversation.id` (`src/nat/observability/exporter/span_exporter.py`) - Tests: `tests/nat/opentelemetry/test_otel_span_ids.py`, `tests/nat/runtime/test_runner_trace_ids.py`, `tests/nat/runtime/test_session_traceparent.py`, updates to `tests/nat/runtime/test_runner.py` **Changed**: - Ensure non-zero 128-bit trace IDs and 64-bit span IDs in OTEL plugin (`packages/nvidia_nat_opentelemetry/src/nat/plugins/opentelemetry/otel_span.py`) - Runner establishes workflow-scoped run/trace IDs and resets them on exit (`src/nat/runtime/runner.py`) - Exporter prefers parent/context trace ID; falls back to workflow trace ID and sets correlated attributes (`src/nat/observability/exporter/span_exporter.py`) - `SpanContext` defaults & field validators enforce size/range and non-zero invariants (`src/nat/data_models/span.py`) - Parse/propagate incoming W3C `traceparent` and workflow headers to session/runner (`src/nat/runtime/session.py`, `tests/nat/runtime/test_session_traceparent.py`) **Removed**: - None **Why it matters**: - Consistent cross-span correlation and easier log/trace joins across agents and sub-spans - Fewer broken traces: eliminates zero/invalid IDs, aligns with OpenTelemetry sizing - Improves debugging and fleet-wide reporting via explicit `.workflow.*` and `.conversation.id` attributes - Safer header handling for external callers; preserves upstream traces **Breaking changes / Migrations**: - None **Docs**: - None ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Workflow-level run and trace IDs are created, stored in context, propagated, and emitted with WORKFLOW_START/WORKFLOW_END events. * Incoming HTTP tracing headers (traceparent, workflow-trace-id, workflow-run-id) are parsed into context. * **Improvements** * Span metadata now includes workflow IDs and richer attributes (event type, function info, timestamps, conversation/run IDs). * ID generation and validation tightened to ensure non-zero, correctly sized trace and span IDs; span context ID generation approach updated. * **Tests** * Added tests validating span ID formats, runner trace/run ID behavior, and header parsing. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Daniel Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
ce04ab2 to
c1aa472
Compare
<!-- Note: The pull request title will be included in the CHANGELOG. --> <!-- Provide a standalone description of changes in this PR. --> <!-- Reference any issues closed by this PR with "closes #1234". All PRs should have an issue they close--> Closes AIQ-1957 - Made the default workflow a react-based workflow - Used `python_safe_workflow_name` instead for the module name - Edited `workflow_commands.py` by replacing `workflow_name` with `package_name`, to ensure imports work (because `package_name` doesn't have `-`) - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **New Features** - Added an echo tool (configurable prefix) and a current_datetime tool to workflows. - Introduced a default NIM LLM using meta/llama-3.1-70b-instruct (temperature 0.0). - Workflows gain LangChain wrapper support and parse-agent response retry set to 3. - **Refactor** - Workflow templates now use a ReAct agent type and reference the NIM LLM and tools. - Generated workflow names/exports now use Python-safe naming conventions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Daniel Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Co-authored-by: Yuchen Zhang <[email protected]> Co-authored-by: Will Killian <[email protected]>
Cleans up the default configuration + workflow template a little more ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - New Features - None - Refactor - Simplified generated workflow configuration by removing redundant logging and frontend blocks and a deprecated retry option. - Aligned workflow registration naming to a consistent convention. - Documentation - Added comprehensive docstrings to the workflow and helper to improve clarity and editor hints. - Chores - Cleaned up default config output to reduce noise and simplify generated templates. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#899 Signed-off-by: Yuchen Zhang <[email protected]>
<!-- Note: The pull request title will be included in the CHANGELOG. --> <!-- Provide a standalone description of changes in this PR. --> <!-- Reference any issues closed by this PR with "closes #1234". All PRs should have an issue they close--> Closes AIQ-1957 - Made the default workflow a react-based workflow - Used `python_safe_workflow_name` instead for the module name - Edited `workflow_commands.py` by replacing `workflow_name` with `package_name`, to ensure imports work (because `package_name` doesn't have `-`) - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **New Features** - Added an echo tool (configurable prefix) and a current_datetime tool to workflows. - Introduced a default NIM LLM using meta/llama-3.1-70b-instruct (temperature 0.0). - Workflows gain LangChain wrapper support and parse-agent response retry set to 3. - **Refactor** - Workflow templates now use a ReAct agent type and reference the NIM LLM and tools. - Generated workflow names/exports now use Python-safe naming conventions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Daniel Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]> Co-authored-by: Yuchen Zhang <[email protected]> Co-authored-by: Will Killian <[email protected]>
Cleans up the default configuration + workflow template a little more ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - New Features - None - Refactor - Simplified generated workflow configuration by removing redundant logging and frontend blocks and a deprecated retry option. - Aligned workflow registration naming to a consistent convention. - Documentation - Added comprehensive docstrings to the workflow and helper to improve clarity and editor hints. - Chores - Cleaned up default config output to reduce noise and simplify generated templates. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#899 Signed-off-by: Yuchen Zhang <[email protected]>
In the last PR NVIDIA#885 I forgot to add this file to the commit, resulting in the bug still persisting. Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - Chores - Updated demo module linting configuration to reduce false-positive warnings and streamline code maintenance. - Adjusted imports to align with available tool integrations, preparing the demo for time and weather-related capabilities. - No changes to existing user workflows or features; behavior remains unchanged. - Tests - No test impact identified. - Documentation - No user-facing documentation changes. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Zhongxuan (Daniel) Wang (https://github.com/zhongxuanwang-nv) URL: NVIDIA#901 Signed-off-by: Yuchen Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/source/reference/cli.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
docs/source/**/*.md
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
docs/source/**/*.md: Use the official naming throughout documentation: first use “NVIDIA NeMo Agent toolkit”, subsequent “NeMo Agent toolkit”; never use deprecated names (Agent Intelligence toolkit, aiqtoolkit, AgentIQ, AIQ/aiq)
Documentation sources are Markdown files under docs/source; images belong in docs/source/_static
Keep docs in sync with code; documentation pipeline must pass Sphinx and link checks; avoid TODOs/FIXMEs/placeholders; avoid offensive/outdated terms; ensure spelling correctness
Do not use words listed in ci/vale/styles/config/vocabularies/nat/reject.txt; accepted terms in accept.txt are allowed
Files:
docs/source/reference/cli.md
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
docs/source/reference/cli.md
docs/source/**/*
⚙️ CodeRabbit configuration file
This directory contains the source code for the documentation. All documentation should be written in Markdown format. Any image files should be placed in the
docs/source/_staticdirectory.
Files:
docs/source/reference/cli.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CI Pipeline / Check
|
/merge |
Description
Closes
By Submitting this PR I confirm:
Summary by CodeRabbit