Skip to content

fix: ensure registration of adk demo functions; reduce warnings #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix: ensure registration of adk demo functions; reduce warnings #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/frameworks/adk_demo/src/nat_adk_demo/nat_time_mcp_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from zoneinfo import ZoneInfo

from nat.builder.builder import Builder
from nat.builder.framework_enum import LLMFrameworkEnum
from nat.builder.function_info import FunctionInfo
from nat.cli.register_workflow import register_function
from nat.data_models.function import FunctionBaseConfig
Expand All @@ -30,7 +31,7 @@ class TimeMCPToolConfig(FunctionBaseConfig, name="get_city_time_tool"):
"""Configuration for the get_city_time tool."""


@register_function(config_type=TimeMCPToolConfig)
@register_function(config_type=TimeMCPToolConfig, framework_wrappers=[LLMFrameworkEnum.ADK])
async def get_city_time(_config: TimeMCPToolConfig, _builder: Builder) -> AsyncIterator[FunctionInfo]:
"""
Register a get_city_time(city: str) -> str tool for ADK.
Expand Down
3 changes: 2 additions & 1 deletion examples/frameworks/adk_demo/src/nat_adk_demo/weather_update_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from collections.abc import AsyncIterator

from nat.builder.builder import Builder
from nat.builder.framework_enum import LLMFrameworkEnum
from nat.builder.function_info import FunctionInfo
from nat.cli.register_workflow import register_function
from nat.data_models.function import FunctionBaseConfig
Expand All @@ -26,7 +27,7 @@ class WeatherToolConfig(FunctionBaseConfig, name="weather_update"):
pass


@register_function(config_type=WeatherToolConfig)
@register_function(config_type=WeatherToolConfig, framework_wrappers=[LLMFrameworkEnum.ADK])
async def weather_update(_config: WeatherToolConfig, _builder: Builder) -> AsyncIterator[FunctionInfo]:

async def _weather_update(city: str) -> str:
Expand Down