Skip to content

Conversation

@dnandakumar-nv
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv commented Oct 1, 2025

Description

Fixes minor issue with documentation for the email phishing analyzer example

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Outputs section updated: added optimized configuration file, per-iteration numeric trial configs, full trials dataframe export, Pareto visualization plots, and explicit per-generation prompt history files alongside existing prompt artifacts.
  • Chores
    • Accepted vocabulary list updated to include the term "Pareto".

Revised the listed outputs to reflect changes in file naming and structure, including the addition of `optimized_config.yml` and trial details. Clarified the location and format of visualization artifacts for better user understanding.

Signed-off-by: dnandakumar-nv <[email protected]>
Revised the listed outputs to reflect changes in file naming and structure, including the addition of `optimized_config.yml` and trial details. Clarified the location and format of visualization artifacts for better user understanding.

Signed-off-by: dnandakumar-nv <[email protected]>
@dnandakumar-nv dnandakumar-nv requested a review from a team as a code owner October 1, 2025 13:07
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link

coderabbitai bot commented Oct 1, 2025

Walkthrough

Updated the example README to list additional optimizer output artifacts and added one accepted vocabulary token; no code, logic, or control-flow changes.

Changes

Cohort / File(s) Summary of changes
Documentation update
examples/evaluation_and_profiling/email_phishing_analyzer/README.md
Expanded Outputs section to enumerate new generated artifacts: optimized_config.yml; per-iteration numeric config files (e.g., config_numeric_trial_0.yml); trials_dataframe_params.csv; plots/ (Pareto visualizations); per-generation prompt history files (e.g., optimized_prompts_gen{N}.json); and adjusted previously listed artifacts.
Vocabulary update
ci/vale/styles/config/vocabularies/nat/accept.txt
Added the token Pareto to the accepted vocabulary list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels
doc

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title “Optimizer doc fix” is a brief noun phrase that does not follow the imperative mood guideline and lacks sufficient context about which documentation is being updated, making it unclear to reviewers what the pull request actually accomplishes. Please revise the title to use imperative mood and clearly describe the change, for example: “Fix optimizer documentation in email phishing analyzer example.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87f7396 and b235765.

📒 Files selected for processing (2)
  • ci/vale/styles/config/vocabularies/nat/accept.txt (1 hunks)
  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • ci/vale/styles/config/vocabularies/nat/accept.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dnandakumar-nv dnandakumar-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Oct 1, 2025
@coderabbitai coderabbitai bot added the doc Improvements or additions to documentation label Oct 1, 2025
Standardize bullet point formatting in the outputs section of the README for better readability and consistency. Adjusted indentation to align all items properly.

Signed-off-by: dnandakumar-nv <[email protected]>
Updated the README to provide more details on the naming conventions for numeric trial configuration files and prompt generation history files. This improves clarity for users analyzing specific trials or generations.

Signed-off-by: dnandakumar-nv <[email protected]>
@willkill07 willkill07 removed the improvement Improvement to existing functionality label Oct 1, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11d3765 and 87f7396.

📒 Files selected for processing (1)
  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/README.@(md|ipynb)

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings

Files:

  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md
examples/**/*

⚙️ CodeRabbit configuration file

examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.

  • If an example contains Python code, it should be placed in a subdirectory named src/ and should
    contain a pyproject.toml file. Optionally, it might also contain scripts in a scripts/ directory.
  • If an example contains YAML files, they should be placed in a subdirectory named configs/. - If an example contains sample data files, they should be placed in a subdirectory named data/, and should
    be checked into git-lfs.

Files:

  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md

@dnandakumar-nv
Copy link
Contributor Author

/ok to test 87f7396

Updated the README to provide more details on the naming conventions for numeric trial configuration files and prompt generation history files. This improves clarity for users analyzing specific trials or generations.

Signed-off-by: dnandakumar-nv <[email protected]>
@dnandakumar-nv
Copy link
Contributor Author

/ok to test 11e3d16

Corrected the capitalization of "Pareto" in the README for consistency and updated the vocabulary in the Vale configuration to include "Pareto" as an accepted term.

Signed-off-by: dnandakumar-nv <[email protected]>
@dnandakumar-nv
Copy link
Contributor Author

/ok to test b235765

@dnandakumar-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ea55327 into NVIDIA:release/1.3 Oct 1, 2025
17 checks passed
nouraellm pushed a commit to nouraellm/NeMo-Agent-Toolkit that referenced this pull request Oct 3, 2025
Fixes minor issue with documentation for the email phishing analyzer example

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.



## Summary by CodeRabbit

* **Documentation**
  * Outputs section updated: added optimized configuration file, per-iteration numeric trial configs, full trials dataframe export, Pareto visualization plots, and explicit per-generation prompt history files alongside existing prompt artifacts.
* **Chores**
  * Accepted vocabulary list updated to include the term "Pareto".

Authors:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: NVIDIA#884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants