-
Notifications
You must be signed in to change notification settings - Fork 412
Optimizer doc fix #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer doc fix #884
Conversation
Revised the listed outputs to reflect changes in file naming and structure, including the addition of `optimized_config.yml` and trial details. Clarified the location and format of visualization artifacts for better user understanding. Signed-off-by: dnandakumar-nv <[email protected]>
Revised the listed outputs to reflect changes in file naming and structure, including the addition of `optimized_config.yml` and trial details. Clarified the location and format of visualization artifacts for better user understanding. Signed-off-by: dnandakumar-nv <[email protected]>
WalkthroughUpdated the example README to list additional optimizer output artifacts and added one accepted vocabulary token; no code, logic, or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
examples/evaluation_and_profiling/email_phishing_analyzer/README.md
Outdated
Show resolved
Hide resolved
Standardize bullet point formatting in the outputs section of the README for better readability and consistency. Adjusted indentation to align all items properly. Signed-off-by: dnandakumar-nv <[email protected]>
Updated the README to provide more details on the naming conventions for numeric trial configuration files and prompt generation history files. This improves clarity for users analyzing specific trials or generations. Signed-off-by: dnandakumar-nv <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/evaluation_and_profiling/email_phishing_analyzer/README.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/README.@(md|ipynb)
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings
Files:
examples/evaluation_and_profiling/email_phishing_analyzer/README.md
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
examples/evaluation_and_profiling/email_phishing_analyzer/README.md
examples/**/*
⚙️ CodeRabbit configuration file
examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.
- If an example contains Python code, it should be placed in a subdirectory named
src/and should
contain apyproject.tomlfile. Optionally, it might also contain scripts in ascripts/directory.- If an example contains YAML files, they should be placed in a subdirectory named
configs/. - If an example contains sample data files, they should be placed in a subdirectory nameddata/, and should
be checked into git-lfs.
Files:
examples/evaluation_and_profiling/email_phishing_analyzer/README.md
examples/evaluation_and_profiling/email_phishing_analyzer/README.md
Outdated
Show resolved
Hide resolved
|
/ok to test 87f7396 |
Updated the README to provide more details on the naming conventions for numeric trial configuration files and prompt generation history files. This improves clarity for users analyzing specific trials or generations. Signed-off-by: dnandakumar-nv <[email protected]>
|
/ok to test 11e3d16 |
Corrected the capitalization of "Pareto" in the README for consistency and updated the vocabulary in the Vale configuration to include "Pareto" as an accepted term. Signed-off-by: dnandakumar-nv <[email protected]>
|
/ok to test b235765 |
|
/merge |
Fixes minor issue with documentation for the email phishing analyzer example ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Outputs section updated: added optimized configuration file, per-iteration numeric trial configs, full trials dataframe export, Pareto visualization plots, and explicit per-generation prompt history files alongside existing prompt artifacts. * **Chores** * Accepted vocabulary list updated to include the term "Pareto". Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: NVIDIA#884
Description
Fixes minor issue with documentation for the email phishing analyzer example
By Submitting this PR I confirm:
Summary by CodeRabbit