[RELEASE] NeMo-Agent-Toolkit v1.2.0 #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "agent" is lower-case outside of headers * Update the default value for `description` to match that used in `src/aiq/agent/react_agent/register.py` * Fix link to reasoning agent documentation Closes #261 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Matthew Penn (https://github.com/mpenn) - https://github.com/lvojtku URL: #293
This PR removes a prompt migration error from an outdated version. Authors: - https://github.com/hsin-c Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #297
Moves the Wikipedia search tool to a separate file. It had been included with Tavily. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Jesse Kornblum (https://github.com/jkornblum-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #237
* Don't run the `update-version.sh` script for releases * Update the release notes document ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - https://github.com/lvojtku - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #300
…dependencies (#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes #239 Closes #241 Closes #224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #284
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #294
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #311
This PR enhances intermediate step processing by including LLM outputs in context and adds a max_concurrency configuration for ragas evaluation. - Pass max_concurrency from builder to RAGEvaluator and use it in the Ragas RunConfig - Extend get_context to filter and label each intermediate step output - Include LLM outputs in get_agent_actions ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Gilberto Titericz Junior (https://github.com/titericz) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #312
* `pytest` now runs without reporting any warnings on 3.12 (there is a warning 3.11 that pytest is unable to silence), down from 46. * Update code to avoid several deprecation warnings (mostly Pydantic) * Silence warnings being emitted by weave that we have no control over (wandb/weave#4533 & wandb/weave#3666) * Add a dependency on `langchain-community` to `aiqtoolkit-test` needed for the `DeterministicFakeEmbedding` class (this is currently a transitory dep of ragas) * Renamed test classes beginning with `Test` which were not test classes, to prevent pytest from attempting to run them. * Avoid mocking the `asyncio.run_coroutine_threadsafe` method, this ensures that coroutines are awaited. * Update `src/aiq/eval/evaluate.py` such that coroutines are only started after passing the `if not session_manager.workflow.has_single_output` check, and in the event of an exception, cancel any running coroutines in the exception handler. * Ignore syntax warnings being emitted by [qdrant-client](https://github.com/qdrant/qdrant-client) used by mem0, remove once the fix for qdrant/qdrant-client#983 is released. Closes #308 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #305
Add documentation for `load_workflow()` to demonstrate the process of creating and using workflows directly from code. Closes [AIQ-1207](https://jirasw.nvidia.com/browse/AIQ-1207) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #306
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Ben O'Mahony (https://github.com/benomahony) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #194
…235) add langfuse and langsmith telemetry exporters with examples Closes #233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #235
* We currently check links for Markdown/RST files included in the documentation builds, however this only covers files under `docs/source` * This PR checks all Markdown files including those at the root of the repo and in the `examples` dir. * Fixes some mal-formatted MD markup * Fixes a broken link in eval documentation Closes #176 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #323
1. Add a link to the RAGAS nv metrics prompts 2. Add a note that the RAGAS nv metrics prompts are not tunable. The user can instead use the "Tunable RAG Evaluator" or add their own "Custom Evaluator" 3. Add a note on the recommended max_tokens for Trajectory Evluator. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #322
This PR adds unit testing for alert_triage_agent in addition to the e2e test. Authors: - https://github.com/hsin-c - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #252
- Add support for AWS Bedrock LLM provider. The provider can be accessed by type `aws_bedrock`, and it is compatible with both `langchain` and `llamaindex` - Added unit tests for existing combinations of existing LLM providers and LLM frameworks. The unit tests are skipped by default, since each of them needs credential to interact with LLM models, but it should be updated and checked each time we add/modify the LLM provider/client to make sure they are still working - Fixed OpenAI + `llamaindex` LLM client that is not working Closes [AIQ-1213](https://jirasw.nvidia.com/browse/AIQ-1213) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) - https://github.com/liamy-nv - Matthew Penn (https://github.com/mpenn) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Ayush Thakur (https://github.com/ayulockin) - Soumili Nandi (https://github.com/soumilinandi) - Eric Evans II (https://github.com/ericevans-nv) - https://github.com/hsin-c - Zac Wang (https://github.com/zac-wang-nv) - Hritik Raj (https://github.com/Hritik003) - Victor Yudin (https://github.com/VictorYudin) - Dhruv Nandakumar (https://github.com/dnandakumar-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #238
Add missing import clause in the documentation. Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #329
- Update the documentation. - Copy of [PR 287](#287) fixing the DCO ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Deepak Sahu (https://github.com/LunaticMaestro) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #298
React agent supports additional_instructions configuration option. Add test cases for custom system prompt and adding additional_instructions. Closes #301 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - https://github.com/gfreeman-nvidia Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #302
I just changed a small installation instruction for the project. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Prince (https://github.com/manny-pi) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #316
* Adds two new endpoints:
- `/generate/async`
- `/generate/async/job/{job_id}`
* Adds a `--max_running_async_jobs` flag to `aiq serve` to control the number of concurrent async generate jobs.
* Similar to the evaluate API the `/generate/async` endpoint optionally receives a user-assigned `job_id` (otherwise one is generated), and an `expiry_seconds` (defaults to an hour).
* Since the payload body of the `/generate` endpoint (`GenerateBodyType`) is determined dynamically, so too is the payload for the async endpoint, however this makes `job_id`, `sync_timeout`, and `expiry_seconds` effectively *reserved* fields.
Usage example:
Terminal 1:
```bash
aiq serve --config_file=examples/simple/configs/config.yml
```
Terminal 2:
```bash
curl -X 'POST' \
'http://localhost:8000/generate/async' \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{"input_message": "What time is it?", "job_id": "1"}' | jq
curl --request GET --url http://localhost:8000/generate/async/job/1
```
#### Open Questions
1) Do we need a GET variant for the `/generate/async` endpoint? I see this for other endpoints, but it doesn't really make sense
2) Do we need an OpenAI variant? If so it would be enabled with `"background": true` in the payload body, however we currently don't enable stream in this way.
3) Currently async evaluations are limited to one concurrent job, should this be updated to use the `max_running_async_jobs` config value?
4) Is issue #313 outside the scope of this PR, or a requirement? I'm currently assuming that it is outside the scope.
5) There is currently no mechanism for canceling long running jobs which may be stuck in an endless loop. I held off on adding this as it started feeling like we were going out of scope of AIQ, and that maybe rather than using Starlette background tasks we should use something like Dask or Celery.
Closes #223
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- David Gardner (https://github.com/dagardner-nv)
Approvers:
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
URL: #315
A small documentation update to help users with 429 errors. Authors: - https://github.com/hsin-c Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #338
This PR renames the test mode of the alert triage agent example to "offline mode" to more accurately reflect its ability to run the full example using an offline dataset, not just for testing purposes. Testing: - All unit tests passed - E2e test passed - Run offline mode, and the output is as expected Authors: - https://github.com/hsin-c - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #343
The PR updates the operation in `offline_mode` to leverage `aiq eval` instead of doing a manual iteration of the test dataframe. This increases the efficiency of the run and also adds evaluation benefits to the example. Authors: - https://github.com/hsin-c - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #344
For MCP tools that have an input that is a flat list, eg
```
{
'items': ['item', 'item']
}
```
The original code led to an invalid pydantic schema like this:
```
{
'items': {'items': {}, 'type': 'array'},
'type': 'array'
}
```
Now the schema is correctly created like this:
```
{
'items': {'type': 'string'},
'type': 'array'
}
```
Confirmed the fix using a JIRA MCP tool.
Closes #342
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- Sean Lopp (https://github.com/slopp)
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
Approvers:
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
URL: #346
This PR moves the default values of tool descriptions into prompt.py and the default prompts into the config objects, so all "prompt-engineerable" strings are tracked in a centralized file and also by the config for easier prompt engineering and version tracking. Authors: - https://github.com/hsin-c Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #350
… requests (#357) Closes #356 This PR extends the `IntermediateStep` data structure with additional `TraceMetadata` attributes that represent tool calling metadata in a tool calling LLM request. The `TraceMetadata` now includes a `tools_schema` attribute that maps to the OpenAI spec for function calling. In addition, the `LangchainProfilerHander` has been extended to populate this new metadata attribute. Finally, the `AsyncOtelSpanListener` has been extended to include the `IntermediateStep.metadata` attribute in OTel spans. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Matthew Penn (https://github.com/mpenn) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: #357
Closes #320 The `otel_telemetry_exporter` function was changed to resolve a potential `AttributeError`. The previous implementation used a class that is not found in the OpenTelemetry's submodule. I've also tried the tracing tool `otelcol` that I made sure can invoke this method explicitly, and after the change it seems that it's working fine. The reason I used the HTTP-based OTLP exporter here is previous examples (`Langfuse` and `Langsmith`) all used the HTTP-based OTLP explicitly. HTTP should also be more broadly accepted and compatible in this case. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Zhongxuan (Daniel) Wang (https://github.com/ZhongxuanWang) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #335
When using any of our agents and the OpenAI provider, token metrics are not reported to telemetry providers because the option `stream_usage` defaults to False in the OpenChatModel object. This sets the default to be `True`, but leaves the option for users to override it as false with extra parameters. Overhead should be minimal. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #328
* Rename to NeMo Agent toolkit ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #359
When installing the example in a standalone manner, we get an error:
```
warning: Missing version constraint (e.g., a lower bound) for `nat-por-to-jiratickets`
warning: Missing version constraint (e.g., a lower bound) for `sphinx-mermaid`
× No solution found when resolving dependencies:
╰─▶ Because only the following versions of nvidia-nat[langchain] are available:
nvidia-nat[langchain]<1.2
nvidia-nat[langchain]>=2.dev0
and nat-por-to-jiratickets==1.2.0rc6.dev9+gc0055ac2.d20250812 depends on nvidia-nat[langchain]>=1.2,<2.dev0, we can conclude that
nat-por-to-jiratickets==1.2.0rc6.dev9+gc0055ac2.d20250812 cannot be used.
And because nat-por-to-jiratickets was not found in the package registry and nat-simple-calculator-hitl==1.2.0rc6.dev20+gd94ec677.d20250813 depends
on nat-por-to-jiratickets, we can conclude that nat-simple-calculator-hitl==1.2.0rc6.dev20+gd94ec677.d20250813 cannot be used.
And because only nat-simple-calculator-hitl==1.2.0rc6.dev20+gd94ec677.d20250813 is available and you require nat-simple-calculator-hitl, we can
conclude that your requirements are unsatisfiable.
```
This PR adds the missing source dependency for `nat_por_to_jiratickets`
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- Will Killian (https://github.com/willkill07)
Approvers:
- Eric Evans II (https://github.com/ericevans-nv)
URL: #638
Closes: #352 This PR enables custom dataset formats by adding a new EvalDatasetCustomConfig class that allows users to specify custom Python functions for dataset transformation. The implementation provides a standardized interface for custom parsers while maintaining compatibility with existing functionality. Adds EvalDatasetCustomConfig class for custom dataset handling Implements custom function loading and execution with error handling Adds preprocessing utilities to apply standard filters and transformations Includes example implementation and documentation ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #615
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #644
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #645
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #646
Added comprehensive UI documentation links to the launching-ui guide and standardized installation instructions for the simple_auth example to improve user onboarding and resource discovery. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eric Evans II (https://github.com/ericevans-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #647
* Use the same container in both CI pipelines * Consolidate `create_env`, `install_rapids_gha_tools` and `get_lfs_files methods` ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #632
* Remove install of `make` which is already in the base container ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #648
* Ensure that `aiq/__init__.py` is installed into the wheel * Replace namespace compatibility alias with custom `importlib.abc.MetaPathFinder` and `importlib.abc.Loader` this solves the issue where a subclass of `aiq.<submodule>.SomeClass` would not be seen as a valid subclass of `nat.<submodule>.SomeClass`. Special thanks to @willkill07 for this! ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #651
* Resolves a bug where some projects specified minimum version of python 3.12 * Updates CI to force the installed version of python to be used instead of another version being downloaded Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #655
Due to changes API changes and deprecations, it is a good idea to have a Migration Guide which outlines migration and compatibility guidelines. This also adds a note to the contributing page which highlights the Migration Guide for new contributions. Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - David Gardner (https://github.com/dagardner-nv) URL: #653
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #657
…uild agents (#656) This PR introduces a series of notebooks along with a few simple tool and agent examples to show new users how to bring an agent into the toolkit and develop new tools and agents using the toolkit. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - https://github.com/cdgamarose-nv - Matthew Penn (https://github.com/mpenn) - Will Killian (https://github.com/willkill07) Approvers: - Matthew Penn (https://github.com/mpenn) - Will Killian (https://github.com/willkill07) URL: #656
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #665
* Introduce additional troubleshooting information due to in-place upgrade from aiq -> nat modules * Restructure Troubleshooting page based on type Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #659
…#654) - Added various badges for license, version, issues, pull requests, GitHub stars, forks, and PyPI downloads to improve visibility and engagement. - Updated the installation section to include specific instructions for installing NeMo Agent Toolkit from PyPI, including optional dependencies. - Reintroduced the Component Overview section with a diagram to provide a high-level view of the toolkit's architecture. - Added a roadmap Closes #624 Remaining Items: - [x] Add link to compatibility document after #653 is merged - [x] Complete the roadmap items - [x] Add an `all` package to `pyproject.toml` - This was accomplished through the creation of three metapackages: `ingestion`, `profiling`, and `all`. This resulted in the fewest duplications of dependencies while adding minimal overhead. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) - Will Killian (https://github.com/willkill07) URL: #654
… scanner (#668) * These are all fake strings used by unittests such as "pass" ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #668
Using pickle for SerDe is not secure, so switch to Pydantic's `model_dump_json` with base64 SerDe for Object Store backing in MySQL. This PR also updates necessary files under the `examples/object_store/user_report` example. The leading `/` was removed as it never should have been added in the first place. Closes AIQ-1724 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #669
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #670
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #672
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #674
- Add `{chat_history}` to both ReAct and ReWOO prompt templates. This enables both agents to get access to the previous chat history in the same conversation session as their context
Closes #327
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- Yuchen Zhang (https://github.com/yczhang-nv)
Approvers:
- Will Killian (https://github.com/willkill07)
- David Gardner (https://github.com/dagardner-nv)
- Michael Demoret (https://github.com/mdemoret-nv)
URL: #673
1.2.0 section in CHANGELOG.md will be used to populate the final release notes before publishing ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - David Gardner (https://github.com/dagardner-nv) - Will Killian (https://github.com/willkill07) - Michael Demoret (https://github.com/mdemoret-nv) - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) - https://github.com/lvojtku URL: #666
dagardner-nv
approved these changes
Aug 19, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
❄️ Code freeze for
developandv1.2.0releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
developuntil release (merging of this PR).What is the purpose of this PR?
developintomainfor the releaseBy Submitting this PR I confirm: