Skip to content

Fix AttributeError bug for otel_telemetry_exporter #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Fix AttributeError bug for otel_telemetry_exporter #335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e22f781
Fix AttributeError bug
ZhongxuanWang Jun 1, 2025
68434ca
Remove an unused import
ZhongxuanWang Jun 1, 2025
aff0ae1
Merge branch 'develop' into second_pr
ZhongxuanWang Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/aiq/observability/register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
from aiq.data_models.logging import LoggingBaseConfig
from aiq.data_models.telemetry_exporter import TelemetryExporterBaseConfig
from aiq.utils.optional_imports import telemetry_optional_import
from aiq.utils.optional_imports import try_import_opentelemetry
from aiq.utils.optional_imports import try_import_phoenix

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -117,9 +116,9 @@ class OtelCollectorTelemetryExporter(TelemetryExporterBaseConfig, name="otelcoll
@register_telemetry_exporter(config_type=OtelCollectorTelemetryExporter)
async def otel_telemetry_exporter(config: OtelCollectorTelemetryExporter, builder: Builder):
"""Create an OpenTelemetry telemetry exporter."""
# If the dependencies are not installed, a TelemetryOptionalImportError will be raised
opentelemetry = try_import_opentelemetry()
yield opentelemetry.sdk.trace.export.OTLPSpanExporter(config.endpoint)

trace_exporter = telemetry_optional_import("opentelemetry.exporter.otlp.proto.http.trace_exporter")
yield trace_exporter.OTLPSpanExporter(endpoint=config.endpoint)


class ConsoleLoggingMethod(LoggingBaseConfig, name="console"):
Expand Down