-
Notifications
You must be signed in to change notification settings - Fork 421
Fix: #32 Recursion Issue #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: atalhens <[email protected]>
|
@sean-javiya-nvidia Can you review these changes? |
Signed-off-by: atalhens <[email protected]>
|
Awesome! Thanks for quickly addressing @atalhens! The last suggestion I have, could we add a unit test for the added improvement? we could maybe add a unit test here, maybe something like this that way, we can ensure any future contributions or changes don't accidentally change the desired behavior |
sean-javiya-nvidia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented above
Signed-off-by: atalhens <[email protected]>
|
Added unit test, Thanks for your suggestion @sean-javiya-nvidia! Let me know if it addresses your concern :) |
|
@atalhens Thanks for your contribution! |
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <[email protected]> * Add str constant for output message Signed-off-by: atalhens <[email protected]> * Add unit test Signed-off-by: atalhens <[email protected]> --------- Signed-off-by: atalhens <[email protected]>
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <[email protected]> * Add str constant for output message Signed-off-by: atalhens <[email protected]> * Add unit test Signed-off-by: atalhens <[email protected]> --------- Signed-off-by: atalhens <[email protected]> Signed-off-by: Yuchen Zhang <[email protected]>
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <[email protected]> * Add str constant for output message Signed-off-by: atalhens <[email protected]> * Add unit test Signed-off-by: atalhens <[email protected]> --------- Signed-off-by: atalhens <[email protected]> Signed-off-by: Yuchen Zhang <[email protected]>
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <[email protected]> * Add str constant for output message Signed-off-by: atalhens <[email protected]> * Add unit test Signed-off-by: atalhens <[email protected]> --------- Signed-off-by: atalhens <[email protected]>
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <[email protected]> * Add str constant for output message Signed-off-by: atalhens <[email protected]> * Add unit test Signed-off-by: atalhens <[email protected]> --------- Signed-off-by: atalhens <[email protected]>
On observing the way, the agent executes the question received from the user: https://github.com/NVIDIA/AgentIQ/blob/develop/src/aiq/agent/react_agent/agent.py#L108.
Looks like there is no sanity check if the input query received from the user side is valid or not.
Edit added to check is the input is like "", " " [empty or blank spaces].
Output will be shown as No human input provided.

Closes #32