Skip to content

fix typo in evaluate documentation for max_concurrency #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

fix typo in evaluate documentation for max_concurrency #191

merged 1 commit into from
May 1, 2025

Conversation

@soumilinandi
Copy link
Contributor

@soumilinandi soumilinandi commented May 1, 2025 •
edited
Loading

Description

changed concurrency to max_concurrency in config parameters of evaluate.md

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented May 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@soumilinandi soumilinandi marked this pull request as draft May 1, 2025 23:33
@soumilinandi soumilinandi marked this pull request as ready for review May 1, 2025 23:35
@soumilinandi
Copy link
Contributor Author

soumilinandi commented May 1, 2025

@AnuradhaKaruppiah requesting review

@AnuradhaKaruppiah
Copy link
Contributor

AnuradhaKaruppiah commented May 1, 2025

@soumilinandi Thx for fixing. Can you please sign-off your commit (this is required by the mandatory DCO checks)? You can do the following to fix it -

  1. git commit --amend

Edit the commit message to add a signed-off line in the end -

Signed-off-by:  FirstName LastName <[email protected]>
  1. git push -f origin develop

@soumilinandi
Copy link
Contributor Author

soumilinandi commented May 1, 2025

@AnuradhaKaruppiah I have signed off. I think this is missing labels which I am not able to assign

@AnuradhaKaruppiah AnuradhaKaruppiah added bug Something isn't working non-breaking Non-breaking change labels May 1, 2025
@AnuradhaKaruppiah
Copy link
Contributor

AnuradhaKaruppiah commented May 1, 2025

/ok to test 76c46c

@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from Copilot May 1, 2025 23:47
Copilot AI reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the evaluation documentation by renaming the configuration parameter from "concurrency" to "max_concurrency".

  • Updated inline documentation text to reflect the correct parameter name.
  • Modified the YAML snippet in the documentation to use "max_concurrency" instead of "concurrency".

@AnuradhaKaruppiah
Copy link
Contributor

AnuradhaKaruppiah commented May 1, 2025

/ok to test 76c46c8

@AnuradhaKaruppiah
Copy link
Contributor

AnuradhaKaruppiah commented May 1, 2025

/merge

@rapids-bot rapids-bot bot merged commit 3c2360e into NVIDIA:develop May 1, 2025
10 checks passed
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@soumilinandi @yczhang-nv
fix typo in evaluate documentation for max_concurrency (NVIDIA#191)
29cee5d 
changed `concurrency` to `max_concurrency` in config parameters of _evaluate.md_

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Soumili Nandi (https://github.com/soumilinandi)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#191
Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 9, 2025
@soumilinandi @yczhang-nv
fix typo in evaluate documentation for max_concurrency (NVIDIA#191)
bf04088 
changed `concurrency` to `max_concurrency` in config parameters of _evaluate.md_

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Soumili Nandi (https://github.com/soumilinandi)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#191
Signed-off-by: Yuchen Zhang <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@soumilinandi @ericevans-nv
fix typo in evaluate documentation for max_concurrency (NVIDIA#191)
bd5d570 
changed `concurrency` to `max_concurrency` in config parameters of _evaluate.md_

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Soumili Nandi (https://github.com/soumilinandi)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#191
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@soumilinandi @ericevans-nv
fix typo in evaluate documentation for max_concurrency (NVIDIA#191)
3b082ec 
changed `concurrency` to `max_concurrency` in config parameters of _evaluate.md_

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Soumili Nandi (https://github.com/soumilinandi)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#191
Signed-off-by: Eric Evans <[email protected]>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@soumilinandi
fix typo in evaluate documentation for max_concurrency (NVIDIA#191)
09a760d 
changed `concurrency` to `max_concurrency` in config parameters of _evaluate.md_

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Soumili Nandi (https://github.com/soumilinandi)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#191
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@soumilinandi
fix typo in evaluate documentation for max_concurrency (NVIDIA#191)
18f8c59 
changed `concurrency` to `max_concurrency` in config parameters of _evaluate.md_

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Soumili Nandi (https://github.com/soumilinandi)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soumilinandi @AnuradhaKaruppiah