Skip to content

Removed disable=unused-argument from pylint checks #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 6, 2025
Merged

Removed disable=unused-argument from pylint checks #186

merged 20 commits into from
May 6, 2025

Conversation

@Hritik003
Copy link
Contributor

@Hritik003 Hritik003 commented May 1, 2025

Description

Closes #151

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Hritik003 and others added 14 commits April 14, 2025 22:55
@Hritik003
Add override option in eval
e1bcb15 
Signed-off-by: Hritik003 <[email protected]>
@Hritik003
Merge branch 'develop' into develop
f7f41a7
@Hritik003
Merge branch 'develop' into develop
8285d7e
@Hritik003
Merge branch 'NVIDIA:develop' into develop
0f276d5
@AnuradhaKaruppiah
Only load config_object plugins
594f91f 
This is for consistency with the start commands

Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Add a note in the evaluate README for override option use
32d3fef 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Use the overriden config for evaluation
30addb6 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Fix overrides handler
df5db56 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Revert whitespace change
3ca7ef9 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Drop duplicate plugin discovery
68e2321 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Fixes from precommit run -a
fd53dee 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@Hritik003
Merge branch 'NVIDIA:develop' into develop
49466fd
@Hritik003
Removed pylint unused-argument
c6e89da 
Signed-off-by: Hritik Raj <[email protected]>
@Hritik003
Merge branch 'NVIDIA:develop' into develop
5d5f559
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagardner-nv dagardner-nv self-assigned this May 1, 2025
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels May 1, 2025
@dagardner-nv
Copy link
Contributor

dagardner-nv commented May 2, 2025

/ok to test b7ebd84

@dagardner-nv
Copy link
Contributor

dagardner-nv commented May 2, 2025

/ok to test e09a2b0

@dagardner-nv
Copy link
Contributor

dagardner-nv commented May 5, 2025

/ok to test 712c452

@dagardner-nv
Copy link
Contributor

dagardner-nv commented May 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit 8c1483d into NVIDIA:develop May 6, 2025
10 checks passed
@dagardner-nv
Copy link
Contributor

dagardner-nv commented May 6, 2025

@Hritik003 thanks for the PR

yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@Hritik003 @yczhang-nv
Removed disable=unused-argument from pylint checks (NVIDIA#186)
1ee2013 
Closes NVIDIA#151

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hritik Raj (https://github.com/Hritik003)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#186
Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 9, 2025
@Hritik003 @yczhang-nv
Removed disable=unused-argument from pylint checks (NVIDIA#186)
251ae1d 
Closes NVIDIA#151

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hritik Raj (https://github.com/Hritik003)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#186
Signed-off-by: Yuchen Zhang <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@Hritik003 @ericevans-nv
Removed disable=unused-argument from pylint checks (NVIDIA#186)
8461362 
Closes NVIDIA#151

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hritik Raj (https://github.com/Hritik003)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#186
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@Hritik003 @ericevans-nv
Removed disable=unused-argument from pylint checks (NVIDIA#186)
e62407a 
Closes NVIDIA#151

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hritik Raj (https://github.com/Hritik003)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#186
Signed-off-by: Eric Evans <[email protected]>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@Hritik003
Removed disable=unused-argument from pylint checks (NVIDIA#186)
4800e71 
Closes NVIDIA#151 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hritik Raj (https://github.com/Hritik003)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#186
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@Hritik003
Removed disable=unused-argument from pylint checks (NVIDIA#186)
e536c59 
Closes NVIDIA#151 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hritik Raj (https://github.com/Hritik003)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA]: Enable unused-argument check in pylint

3 participants

@Hritik003 @dagardner-nv @AnuradhaKaruppiah