Skip to content

Add colorama to core dependency #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

Add colorama to core dependency #149

merged 2 commits into from
Apr 26, 2025

Conversation

@yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Apr 25, 2025

Description

Add colorama to core dependency to fix import error.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 25, 2025
@yczhang-nv yczhang-nv self-assigned this Apr 25, 2025
@yczhang-nv yczhang-nv requested a review from a team as a code owner April 25, 2025 23:49
@yczhang-nv yczhang-nv enabled auto-merge (squash) April 25, 2025 23:50
@yczhang-nv yczhang-nv disabled auto-merge April 25, 2025 23:50
@yczhang-nv yczhang-nv enabled auto-merge (squash) April 25, 2025 23:50
@yczhang-nv
update uv.lock
df7a6ba 
Signed-off-by: Yuchen Zhang <[email protected]>
@yczhang-nv yczhang-nv merged commit e1a8eaa into NVIDIA:develop Apr 26, 2025
9 checks passed
@yczhang-nv yczhang-nv deleted the yuchen-fix-colorama-dependency-issue branch April 26, 2025 00:03
yczhang-nv added a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@yczhang-nv
Update colorama to core dependency (NVIDIA#149)
a8b3ad4 
Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@yczhang-nv
Update colorama to core dependency (NVIDIA#149)
9668b77 
Signed-off-by: Yuchen Zhang <[email protected]>
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@yczhang-nv
Update colorama to core dependency (NVIDIA#149)
4d65968 
Signed-off-by: Yuchen Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yczhang-nv @willkill07