Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance POC notebook and docs #3031

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Enhance POC notebook and docs #3031

merged 3 commits into from
Oct 11, 2024

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator

@SYangster do we want same changes in 2.5?

YuanTingHsieh
YuanTingHsieh approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit b704c98 into NVIDIA:main Oct 11, 2024
20 checks passed
SYangster added a commit to SYangster/NVFlare that referenced this pull request Oct 11, 2024
@SYangster @YuanTingHsieh
Enhance POC notebook and docs (NVIDIA#3031)
5b302bf 
* 2.5 vdr enhancements

* add table

---------

Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
@SYangster SYangster mentioned this pull request Oct 11, 2024
Merged
6 tasks
chesterxgchen pushed a commit that referenced this pull request Oct 11, 2024
@SYangster @YuanTingHsieh
[2.5] Enhance POC notebook and docs (#3033)
fa135de 
* Enhance POC notebook and docs (#3031)

* 2.5 vdr enhancements

* add table

---------

Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>

* multi line table

---------

Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @YuanTingHsieh