Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ml-to-fl examples with new APIs #2836

Merged
merged 5 commits into from
Aug 24, 2024
Merged

Update ml-to-fl examples with new APIs #2836

merged 5 commits into from
Aug 24, 2024

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster force-pushed the ml_fl_updates branch 2 times, most recently from 8efa368 to 40e9e7c Compare August 23, 2024 19:59
@chesterxgchen
Copy link
Collaborator

@SYangster need to rebase the code

chesterxgchen
chesterxgchen reviewed Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have bunch of question

why converting "code" to "src" ? consistency ? this could lead many potential errors for missing changes

examples/hello-world/ml-to-fl/np/README.md Show resolved Hide resolved
examples/hello-world/ml-to-fl/np/README.md Outdated Show resolved Hide resolved
examples/hello-world/ml-to-fl/np/src/train_full.py Outdated Show resolved Hide resolved
examples/hello-world/ml-to-fl/np/src/train_metrics.py Show resolved Hide resolved
@SYangster
Copy link
Collaborator Author

SYangster commented Aug 23, 2024 •
edited
Loading

For renaming folder from code -> src: this is for consistency, but also code is an internal module in the python standard library. So in the job scripts from code.tf_net import TFNet will not work

@SYangster SYangster force-pushed the ml_fl_updates branch 2 times, most recently from 7d1abde to f01d8b9 Compare August 23, 2024 21:48
chesterxgchen
chesterxgchen previously approved these changes Aug 23, 2024
View reviewed changes
@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen chesterxgchen merged commit a6e1100 into NVIDIA:main Aug 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @chesterxgchen