Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py for base version and nightly build #2644

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update setup.py for base version and nightly build #2644

merged 1 commit into from
Jun 13, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Description

Update the setup.py on version number and improve the way to get the base version. Mainly for non-release build.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@IsaacYangSLA
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (rebase) June 13, 2024 18:55
SYangster
SYangster approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacYangSLA IsaacYangSLA merged commit 0cc9341 into NVIDIA:main Jun 13, 2024
16 checks passed
@IsaacYangSLA IsaacYangSLA deleted the jenkins_nightly branch July 31, 2024 21:02
@IsaacYangSLA IsaacYangSLA restored the jenkins_nightly branch July 31, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaacYangSLA @SYangster