-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing sj heartbeat #2583
Missing sj heartbeat #2583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. See my comments for improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check cell before sending request.
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added the missing SJ heartbeat, fixed the early abort_job command issue. * codestyle fix. * Removed the no use constant. * Refactored. --------- Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
Fixes # .
Description
Add the missing SJ heartbeat calls to the parent. Add the logic to abort the job if it's not supposed to be running.
Types of changes
./runtest.sh
.