Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Bump up monai nvflare #2572

Merged
merged 1 commit into from
May 9, 2024
Merged

[2.4] Bump up monai nvflare #2572

merged 1 commit into from
May 9, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Description

Update the monai_nvflare setup.py to 0.2.8 and its nvflare dependency to ~=2.4.1rc8

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@IsaacYangSLA IsaacYangSLA changed the base branch from main to 2.4 May 9, 2024 17:29
@IsaacYangSLA
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen changed the title Bump up monai nvflare [2.4] Bump up monai nvflare May 9, 2024
chesterxgchen
chesterxgchen approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacYangSLA IsaacYangSLA merged commit 5498c7d into 2.4 May 9, 2024
16 checks passed
@IsaacYangSLA IsaacYangSLA deleted the bump_up_monai_nvflare branch May 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaacYangSLA @chesterxgchen