Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Fix global steps in MLflow example #2571

Merged
merged 1 commit into from
May 9, 2024
Merged

[2.4] Fix global steps in MLflow example #2571

merged 1 commit into from
May 9, 2024

Conversation

chesterxgchen
Copy link
Collaborator

Fixes # .
global step calculation bug

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

ZiyueXu77
ZiyueXu77 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given
steps = local_epochs * len(trainloader), representing steps in a round

IsaacYangSLA
IsaacYangSLA approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Small bug in the formula.

@IsaacYangSLA
Copy link
Collaborator

/build

@IsaacYangSLA IsaacYangSLA merged commit 5171404 into NVIDIA:2.4 May 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacYangSLA IsaacYangSLA IsaacYangSLA approved these changes

@ZiyueXu77 ZiyueXu77 ZiyueXu77 approved these changes

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chesterxgchen @IsaacYangSLA @ZiyueXu77