Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Backport AWS VPC/Subnet enhancement from main branch #2568

Merged
merged 1 commit into from
May 8, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Description

Backport this feature from main branch to 2.4.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@IsaacYangSLA IsaacYangSLA changed the title Backport AWS VPC/Subnet enhancement from main branch [2.4] Backport AWS VPC/Subnet enhancement from main branch May 8, 2024
chesterxgchen
chesterxgchen previously approved these changes May 8, 2024
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo, other LGTM

nvflare/dashboard/cli.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@IsaacYangSLA
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (rebase) May 8, 2024 21:49
@IsaacYangSLA IsaacYangSLA merged commit def9adf into NVIDIA:2.4 May 8, 2024
16 checks passed
@IsaacYangSLA IsaacYangSLA deleted the aws_vpc_cherry-pick branch July 31, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants