Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Add missing client api test jobs #2531

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[2.4] Add missing client api test jobs #2531

merged 1 commit into from
Apr 29, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Add missing test jobs

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Apr 25, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh changed the title [2.4] Add missing test jobs [2.4] Add missing client api test jobs Apr 28, 2024
@YuanTingHsieh
Copy link
Collaborator Author

The tests configs were included here: #2503

chesterxgchen
chesterxgchen approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the same as main branch.

@YuanTingHsieh
Copy link
Collaborator Author

Yes, these testing examples are the same.

Both branches I've already merged the test configs

@YuanTingHsieh
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit 3ddf69f into NVIDIA:2.4 Apr 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
cicd continuous integration/continuous development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @chesterxgchen