Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Added more logging for the job status changing #2481

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Apr 10, 2024

Fixes # .

Description

Added more logging for the job status changing.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yhwen yhwen changed the title Added more logging for the job status changing. Added more logging for the job status changing -- 2.4 branch Apr 10, 2024
@chesterxgchen chesterxgchen changed the title Added more logging for the job status changing -- 2.4 branch [2.4] Added more logging for the job status changing Apr 10, 2024
chesterxgchen
chesterxgchen previously approved these changes Apr 10, 2024
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more log messages. See my comments.

nvflare/private/fed/server/job_runner.py Show resolved Hide resolved
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@yhwen yhwen merged commit 8dcac91 into NVIDIA:2.4 Apr 10, 2024
15 checks passed
@yhwen yhwen deleted the job_running_status_logging_2.4 branch May 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants