Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Use unbuffered python launch #2472

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[2.4] Use unbuffered python launch #2472

merged 1 commit into from
Apr 5, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Fixes #2398 .

Description

Let external process be un-buffered so users can see results right away.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh linked an issue Apr 5, 2024 that may be closed by this pull request
Missing classification results for the FL linear regression tutorial #2398
Closed
ZiyueXu77
ZiyueXu77 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I still wonder why we did not have this issue in the past (before recent bug report)?

@YuanTingHsieh
Copy link
Collaborator Author

@ZiyueXu77 we did found some problems before so we got #2120 #2350 #2351

@ZiyueXu77
Copy link
Collaborator

@ZiyueXu77 we did found some problems before so we got #2120 #2350 #2351

I see, thanks!

IsaacYangSLA
IsaacYangSLA approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the python scripts launch more consistent with our startup kits. LGTM.

@YuanTingHsieh
Copy link
Collaborator Author

/build

1 similar comment
@YuanTingHsieh
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit 418fe1d into NVIDIA:2.4 Apr 5, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the use_unbuffered_launch_job_templates_24 branch April 8, 2024 18:05
@YuanTingHsieh YuanTingHsieh mentioned this pull request Apr 9, 2024
Closed
YuanTingHsieh added a commit to YuanTingHsieh/NVFlare that referenced this pull request Aug 6, 2024
@YuanTingHsieh
Use unbuffered python launch (NVIDIA#2472)
73998cb
@YuanTingHsieh YuanTingHsieh mentioned this pull request Aug 6, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@IsaacYangSLA IsaacYangSLA IsaacYangSLA approved these changes

@ZiyueXu77 ZiyueXu77 ZiyueXu77 approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing classification results for the FL linear regression tutorial
4 participants
@YuanTingHsieh @ZiyueXu77 @chesterxgchen @IsaacYangSLA