-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.4] Use unbuffered python launch #2472
[2.4] Use unbuffered python launch #2472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I still wonder why we did not have this issue in the past (before recent bug report)?
@ZiyueXu77 we did found some problems before so we got #2120 #2350 #2351 |
I see, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes the python scripts launch more consistent with our startup kits. LGTM.
/build |
1 similar comment
/build |
Fixes #2398 .
Description
Let external process be un-buffered so users can see results right away.
Types of changes
./runtest.sh
.