Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Add garbage collect at ends of round-based workflows #2464

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[2.4] Add garbage collect at ends of round-based workflows #2464

merged 1 commit into from
Apr 3, 2024

Conversation

SYangster
Copy link
Collaborator

Same as #2463 for 2.4 branch

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yanchengnv
yanchengnv approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh linked an issue Apr 3, 2024 that may be closed by this pull request
[BUG] Host memory increases steadily over time when using the Scatter and Gather component #2461
Closed
@SYangster SYangster merged commit d7ed910 into NVIDIA:2.4 Apr 3, 2024
16 checks passed
@SYangster SYangster deleted the gc_collect_2.4 branch April 3, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Host memory increases steadily over time when using the Scatter and Gather component
2 participants
@SYangster @yanchengnv