Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Improve reliable message #2452

Merged
merged 9 commits into from
Apr 1, 2024
Merged

[2.4] Improve reliable message #2452

merged 9 commits into from
Apr 1, 2024

Conversation

yanchengnv
Copy link
Collaborator

Fixes # .

Description

This PR improves the ReliableMessage (RM) mechanism:

  • Automatically enable RM so that user won't need to manually configure
  • No need to set sender_id in XGB Executor configuration
  • Added detailed log messages for tracing/debugging RM process

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

nvidianz
nvidianz previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

nvflare/apis/fl_constant.py Outdated Show resolved Hide resolved
@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh changed the title Improve reliable message [2.4] Improve reliable message Apr 1, 2024
@YuanTingHsieh YuanTingHsieh merged commit 84a1a98 into NVIDIA:2.4 Apr 1, 2024
16 checks passed
@yanchengnv yanchengnv mentioned this pull request Apr 2, 2024
Merged
6 tasks
@YuanTingHsieh YuanTingHsieh mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@nvidianz nvidianz nvidianz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanchengnv @YuanTingHsieh @nvidianz