Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Update setup.py of monai integration folder #2449

Merged
merged 2 commits into from
Mar 26, 2024
Merged

[2.4] Update setup.py of monai integration folder #2449

merged 2 commits into from
Mar 26, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Description

This PR updates the dependencies and version of monai_nvflare build configuration (setup.py).

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a question

@IsaacYangSLA
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA changed the title Update setup.py of monai integration folder [2.4] Update setup.py of monai integration folder Mar 26, 2024
YuanTingHsieh
YuanTingHsieh approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@IsaacYangSLA
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (squash) March 26, 2024 21:50
@IsaacYangSLA IsaacYangSLA merged commit b56e867 into NVIDIA:2.4 Mar 26, 2024
16 checks passed
@IsaacYangSLA IsaacYangSLA deleted the monai_nvflare branch July 31, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

@SYangster SYangster Awaiting requested review from SYangster

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IsaacYangSLA @chesterxgchen @YuanTingHsieh