Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Update finance example using job templates #2448

Merged
merged 2 commits into from
Mar 26, 2024
Merged

[2.4] Update finance example using job templates #2448

merged 2 commits into from
Mar 26, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

  • Update finance example to use job templates
  • Update finance example to use new xgboost (V2)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the examples Label for all example related work label Mar 26, 2024
SYangster
SYangster approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh YuanTingHsieh merged commit ebccc48 into NVIDIA:2.4 Mar 26, 2024
15 checks passed
@YuanTingHsieh YuanTingHsieh deleted the update_finance_example_24 branch March 26, 2024 20:59
@YuanTingHsieh YuanTingHsieh mentioned this pull request Aug 22, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

Assignees
No one assigned
Labels
examples Label for all example related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YuanTingHsieh @SYangster