Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Check wandb login #2444

Merged
merged 4 commits into from
Mar 26, 2024
Merged

[2.4] Check wandb login #2444

merged 4 commits into from
Mar 26, 2024

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Mar 25, 2024 •
edited

  • Fixes 1890
  • Check wandb login, run job to completion with wandb in offline mode if login is unsuccessful

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster changed the title Check wandb login [2.4] Check wandb login Mar 25, 2024
@SYangster SYangster mentioned this pull request Mar 25, 2024
Merged
6 tasks
YuanTingHsieh
YuanTingHsieh previously approved these changes Mar 25, 2024
View reviewed changes
YuanTingHsieh
YuanTingHsieh approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster enabled auto-merge (squash) March 26, 2024 01:06
@SYangster SYangster merged commit a739d8a into NVIDIA:2.4 Mar 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SYangster @chesterxgchen @YuanTingHsieh