Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Lightning API Patch just once #2416

Merged
merged 2 commits into from
Mar 19, 2024
Merged

[2.4] Lightning API Patch just once #2416

merged 2 commits into from
Mar 19, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

If users calling patch many times, we should not append more than one FLCallback and/or RestoreState

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 5b88e43 into NVIDIA:2.4 Mar 19, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the lightning_api_patch_just_once_24 branch March 19, 2024 20:02
@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 20, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YuanTingHsieh @chesterxgchen