-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.4] Integrated ReliableMessage with XGBoost #2399
[2.4] Integrated ReliableMessage with XGBoost #2399
Conversation
3f846fa
to
3cd2bd2
Compare
3cd2bd2
to
aa821b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments.
nvflare/app_opt/xgboost/histogram_based_v2/adaptor_controller.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Please change sender signature as commented.
81d58fa
to
663a60e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think RequestSender is needed.
750666b
to
3670222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, Have a question
3670222
to
fe31704
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
nvflare/app_opt/xgboost/histogram_based_v2/adaptors/grpc_client_adaptor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nvflare/app_opt/xgboost/histogram_based_v2/adaptors/grpc_client_adaptor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nvflare/app_opt/xgboost/histogram_based_v2/adaptors/grpc_client_adaptor.py
Outdated
Show resolved
Hide resolved
/build |
Description
Integrated ReliableMessage with XGBoost. By default, the simple sender will be used. To use ReliableMessage, add this component and specify the sender_id in executor,
Types of changes
./runtest.sh
.