Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Added ReliableMessage #2394

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[2.4] Added ReliableMessage #2394

merged 1 commit into from
Mar 8, 2024

Conversation

nvidianz
Copy link
Collaborator

@nvidianz nvidianz commented Mar 8, 2024

Description

Added ReliableMessage to 2.4

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh changed the title Added ReliableMessage [2.4] Added ReliableMessage Mar 8, 2024
YuanTingHsieh
YuanTingHsieh approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 8, 2024
Closed
@nvidianz nvidianz merged commit b66da2a into NVIDIA:2.4 Mar 8, 2024
15 of 16 checks passed
@nvidianz nvidianz deleted the reliable-aux-message-2.4 branch March 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvidianz @YuanTingHsieh