Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Add xgboost example, unit tests, integration tests #2392

Merged
merged 7 commits into from
Mar 8, 2024
Merged

[2.4] Add xgboost example, unit tests, integration tests #2392

merged 7 commits into from
Mar 8, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Mar 7, 2024 •
edited

Description

  • Add xgboost example for v2
  • Add unit tests (tests/unit_test/app_opt/xgboost/histrogram_based_v2/)
  • Add integration tests (xgb_test.py and the tests that run examples)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added documentation Improvements or additions to documentation cicd continuous integration/continuous development labels Mar 7, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

yanchengnv
yanchengnv requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive!
I added some minor comments. Please take a look.

examples/advanced/xgboost/histogram-based/jobs/base_v2/app/config/config_fed_server.json Outdated Show resolved Hide resolved
examples/advanced/xgboost/tree-based/jobs/bagging_base/app/config/config_fed_server.json Outdated Show resolved Hide resolved
nvflare/app_opt/xgboost/histogram_based_v2/adaptors/grpc_client_adaptor.py Outdated Show resolved Hide resolved
tests/integration_test/src/mock_xgb/aggr_servicer.py Show resolved Hide resolved
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 8, 2024
Closed
@YuanTingHsieh
Copy link
Collaborator Author

/build

yanchengnv
yanchengnv approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@YuanTingHsieh YuanTingHsieh merged commit 4946ac6 into NVIDIA:2.4 Mar 8, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the add_xgboost_histogram_v2_24 branch March 8, 2024 21:31
This was referenced Aug 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen left review comments

@yanchengnv yanchengnv yanchengnv approved these changes

@SYangster SYangster Awaiting requested review from SYangster

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@nvidianz nvidianz Awaiting requested review from nvidianz

@yhwen yhwen Awaiting requested review from yhwen

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
cicd continuous integration/continuous development documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YuanTingHsieh @chesterxgchen @yanchengnv