-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller Refactor Part 1: separate communication #2390
Conversation
c8eae20
to
fc753bc
Compare
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very impressive! I like it that all existing controllers don't need changes (other than change some imports).
We need to make the WFCommSpec more complete (see my comments). I understand that most of these are only specific to the server side (for now), but the concept is good and may still be applicable to other implementations. The default impl of these methods can raise exception NOT_IMPLEMENTED.
fc753bc
to
672d74b
Compare
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update:
Responder: handle_dead_job()
andControllerSpec: process_result_of_unknown_task()
are implemented by some Controller subclasses, but are needed by the WFCommServer. For now I passed the Controller to the WFCommServer, but maybe need a cleaner solution.Types of changes
./runtest.sh
.