Skip to content

fix hybrid model subblock param counting: all FFN sizes reported identical params#1258

Merged
kevalmorabia97 merged 5 commits into
feature/puzzletronfrom
jrausch/nemotron-h-fix-pattern-truncation
Apr 15, 2026
Merged

fix hybrid model subblock param counting: all FFN sizes reported identical params#1258
kevalmorabia97 merged 5 commits into
feature/puzzletronfrom
jrausch/nemotron-h-fix-pattern-truncation

Fix test assertions

9afd4a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 15, 2026 in 1s

65.29% (-11.04%) compared to 38d9522

View this Pull Request on Codecov

65.29% (-11.04%) compared to 38d9522

Details

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.29%. Comparing base (38d9522) to head (9afd4a7).
⚠️ Report is 12 commits behind head on feature/puzzletron.

Files with missing lines Patch % Lines
...h/puzzletron/subblock_stats/calc_subblock_stats.py 25.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (38d9522) and HEAD (9afd4a7). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (38d9522) HEAD (9afd4a7)
unit 2 1
examples 10 9
gpu 3 2
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/puzzletron    #1258       +/-   ##
=======================================================
- Coverage               76.33%   65.29%   -11.04%     
=======================================================
  Files                     454      454               
  Lines                   48025    48104       +79     
=======================================================
- Hits                    36660    31411     -5249     
- Misses                  11365    16693     +5328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.