-
Notifications
You must be signed in to change notification settings - Fork 451
Activation hooks redesign (reuse hooks component across both minitron and puzzletron) #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielkorzekwa
merged 12 commits into
main
from
dkorzewa/activation_hooks_redesign_minitron_puzzletron
Mar 24, 2026
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8e99b24
Add shared activation hooks infrastructure for minitron and puzzletron
danielkorzekwa dcf0c6d
Add logger dependency for activation hooks
danielkorzekwa 81caac9
Add a logger and json_dump needed by base_hooks (TODO: both should be…
danielkorzekwa 38f24ea
Fix a broken test due to a missing random seed.
danielkorzekwa 1c62a10
Logging and robust_json refactoring.
danielkorzekwa d63f056
Delete not needed logger and robust_json (moved to modelopt)
danielkorzekwa c2bdf09
Change the location for activation hooks from nas..... to prune.impor…
danielkorzekwa 92cca42
Add a security comment why using torch.load(weight_only=False)
danielkorzekwa 945cdb6
No need for computing gradients during a loop for activation hooks an…
danielkorzekwa d1e3417
code clean up
danielkorzekwa 5b48ec6
remove max_size
kevalmorabia97 7f16f90
remove strict assertions in test_mcore_gpt_minitron_pruning
kevalmorabia97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Forward hooks for estimating importance scores for pruning.""" | ||
|
|
||
| from modelopt.torch.utils import import_plugin | ||
|
|
||
| from .base_hooks import * | ||
| from .base_hooks_analysis import * | ||
|
|
||
| with import_plugin("megatron_hooks"): | ||
| from .plugins.megatron_hooks import * |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.