Skip to content
Merged
Show file tree
Hide file tree
Changes from 80 commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
e82164f
Add anymodel directories to feature/puzzletron
danielkorzekwa Mar 4, 2026
2099df3
Make any_model conversion working.
danielkorzekwa Mar 5, 2026
eb5cf8a
Update child_init.py with anymodel version
danielkorzekwa Mar 5, 2026
c9de41c
fix attention pruning
danielkorzekwa Mar 5, 2026
3c1bc1f
Add trust_remote_code to load_model_config (default to false)
danielkorzekwa Mar 5, 2026
8357136
Make activation scoring working
danielkorzekwa Mar 5, 2026
6cc2194
Comment all tested models aside of llama_3_1_8b_instruct
danielkorzekwa Mar 5, 2026
ee4e1e3
Delete not needed decilm test
danielkorzekwa Mar 5, 2026
449b523
Fix broken tests
danielkorzekwa Mar 5, 2026
fb27bba
Update puzzletron_nas_pluging to any_model version
danielkorzekwa Mar 5, 2026
b350f82
Correct test resources used by tests.
danielkorzekwa Mar 5, 2026
fafe5a3
Disable puzzletron tests (will be enabled after all any_model logic i…
danielkorzekwa Mar 5, 2026
e988248
Merge branch 'dkorzekwa/anymodel_core' into dkorzekwa/anymodel_activa…
danielkorzekwa Mar 6, 2026
c717852
Comment out not implemented models.
danielkorzekwa Mar 6, 2026
030f126
format python docs
danielkorzekwa Mar 6, 2026
8dcdfbf
Merge branch 'dkorzekwa/anymodel_core' into dkorzekwa/anymodel_activa…
danielkorzekwa Mar 6, 2026
70df0df
Use trust_remote_code in force_cache_dynamic_modules()
danielkorzekwa Mar 6, 2026
bb56662
Merge branch 'dkorzekwa/anymodel_core' into dkorzekwa/anymodel_activa…
danielkorzekwa Mar 6, 2026
ecd953e
Fix anymodel pruning
danielkorzekwa Mar 6, 2026
ee8f538
Fix buid docs issue.
danielkorzekwa Mar 6, 2026
c9b76a1
Merge branch 'dkorzekwa/anymodel_core' into dkorzekwa/anymodel_activa…
danielkorzekwa Mar 6, 2026
6e3af61
Merge branch 'dkorzekwa/anymodel_activation_scoring' into dkorzekwa/a…
danielkorzekwa Mar 6, 2026
0ad6d92
Merging build_library_and_stats
danielkorzekwa Mar 6, 2026
995eb1a
Merging anymodel: calc_one_block_scores
danielkorzekwa Mar 6, 2026
34081c9
Mering any_model: calc_one_block_scores
danielkorzekwa Mar 6, 2026
ed5c00f
merge any_model: mip_and_realize_models
danielkorzekwa Mar 6, 2026
993b5ec
Add all anymodel models but gptoss
danielkorzekwa Mar 6, 2026
6e9f03b
Make nemotron-nano-12b-v2 to work (set trust_remote_code=true)
danielkorzekwa Mar 9, 2026
e8b7a7d
merge anymodel for nemotron-3-nano-30b-a3b-base-bf16
danielkorzekwa Mar 9, 2026
47414d5
Clarify readme and avoid reusing the same reference in llama_converter.
danielkorzekwa Mar 9, 2026
a8305d8
Fix tied-embedding handling before writing the safetensors index.
danielkorzekwa Mar 9, 2026
68421a5
Fix NaN ranking currently selects NaNs as “best” experts by default.
danielkorzekwa Mar 9, 2026
d6b8028
Code clean up.
danielkorzekwa Mar 9, 2026
ecd2341
Code clean up.
danielkorzekwa Mar 10, 2026
f9d845d
code clean up
danielkorzekwa Mar 10, 2026
d171b01
Merge branch 'dkorzekwa/anymodel_core' into dkorzekwa/anymodel_activa…
danielkorzekwa Mar 10, 2026
722da90
Merge branch 'dkorzekwa/anymodel_activation_scoring' into dkorzekwa/a…
danielkorzekwa Mar 10, 2026
934ab2f
code clean up
danielkorzekwa Mar 10, 2026
0f14ec3
Merge branch 'dkorzekwa/anymodel_pruning' into dkorzekwa/anymodel_bui…
danielkorzekwa Mar 10, 2026
dcb9e02
remove not needed comment
danielkorzekwa Mar 10, 2026
0c9ea5d
Merge branch 'dkorzekwa/anymodel_build_library_and_stats' into dkorze…
danielkorzekwa Mar 10, 2026
5b310e2
Merge branch 'dkorzekwa/any_model_calc_one_block_scores' into dkorzek…
danielkorzekwa Mar 10, 2026
4f82b1c
Merge branch 'dkorzekwa/mip_and_realize_models' into dkorzekwa/any_mo…
danielkorzekwa Mar 10, 2026
176a435
Fix a broken test_puzzletron test on 2 gpus.
danielkorzekwa Mar 10, 2026
02e2c9b
Merge branch 'dkorzekwa/anymodel_activation_scoring' into dkorzekwa/a…
danielkorzekwa Mar 10, 2026
92c4419
Merge branch 'dkorzekwa/anymodel_pruning' into dkorzekwa/anymodel_bui…
danielkorzekwa Mar 10, 2026
aa1eb3e
Merge branch 'dkorzekwa/anymodel_build_library_and_stats' into dkorze…
danielkorzekwa Mar 10, 2026
2b84a96
Merge branch 'dkorzekwa/any_model_calc_one_block_scores' into dkorzek…
danielkorzekwa Mar 10, 2026
fb838c0
Merge branch 'dkorzekwa/mip_and_realize_models' into dkorzekwa/any_mo…
danielkorzekwa Mar 10, 2026
13378ff
Add gpt-oss model
danielkorzekwa Mar 11, 2026
47ca0e3
Add comments about a broken test
danielkorzekwa Mar 11, 2026
96112f7
Fix a broken gptoss test
danielkorzekwa Mar 12, 2026
cb6b182
Add mamba to puzzletron dependencies.
danielkorzekwa Mar 12, 2026
670bb34
Update mamba-ssm and casual-conv1d dependences (remove pinpoint versi…
danielkorzekwa Mar 13, 2026
0e1b591
Install mamba-ssm and causal-conv1d in testenv:cuda13-gpu-puzzletron
danielkorzekwa Mar 13, 2026
ca845ec
Fix installing dependencies in testenv:cuda13-gpu-puzzletron
danielkorzekwa Mar 13, 2026
be825bc
Fix anymodel for qwen3 8B in 2 gpus
danielkorzekwa Mar 13, 2026
7fd1afa
Fix pipeline parallelism issue for wen3-vl-30b-a3b-instruct-qwen3_vl-…
danielkorzekwa Mar 13, 2026
7d7b609
Fix multi-gpu issue for nemotron-nano-12b-v2
danielkorzekwa Mar 13, 2026
249af9d
Fix no_op in any_model
danielkorzekwa Mar 13, 2026
b80583c
Merge branch 'feature/puzzletron' into dkorzekwa/any_model_other_models
danielkorzekwa Mar 13, 2026
1dd742e
Fix nemotron_h_model_descriptor.
danielkorzekwa Mar 14, 2026
4a6ebbe
Fix tox -e build-docs
danielkorzekwa Mar 14, 2026
585f0ed
pin mamba/casual-conv1d versions to fix failing assertion for test_pu…
danielkorzekwa Mar 14, 2026
7fb5d9a
Fix for installing mamba-ssm
danielkorzekwa Mar 14, 2026
75d3d69
Fix broken test for nemotron-3-nano-30b-a3b-base-bf16
danielkorzekwa Mar 14, 2026
0e5722d
code clean up
danielkorzekwa Mar 14, 2026
2dd9735
Make test_puzzletron test deterministic
danielkorzekwa Mar 15, 2026
3561de5
Comment out all models but nemotron-3-nano-30b-a3b-base-bf16 to check…
danielkorzekwa Mar 15, 2026
27866de
Implement Qwen3VLRemoveExpertsIndependentHook
danielkorzekwa Mar 15, 2026
a012fe6
Remove not needed nvidia licence header
danielkorzekwa Mar 16, 2026
52922a4
# Initialize weights to ensure all parameters are properly initialized
danielkorzekwa Mar 16, 2026
c234fb4
Fix non-deterministic test_puzzletron test
danielkorzekwa Mar 16, 2026
53dcd10
Fix for unsetting CUDA_VISIBLE_DEVICES
danielkorzekwa Mar 16, 2026
69d9648
increase numeric tolerance for test_puzzletron.py
danielkorzekwa Mar 17, 2026
4a692dc
Disable lm_loss assertion for nemotron-3-nano-30b-a3b-base-bf16 (not …
danielkorzekwa Mar 17, 2026
e795f0c
Removing incorrect licence file. gpt_oss_pruned_to_mxfp4.py was not a…
danielkorzekwa Mar 17, 2026
631306c
Fix hardcoded trust_remote_code
danielkorzekwa Mar 17, 2026
dc77be2
Merge branch 'dkorzekwa/any_model_other_models' into dkorzekwa/anymod…
danielkorzekwa Mar 17, 2026
5cadc65
Merge branch 'feature/puzzletron' into dkorzekwa/anymodel_gptoss
danielkorzekwa Mar 17, 2026
151081c
Delete not needed yaml files for test_puzzletron.
danielkorzekwa Mar 17, 2026
36daa6d
Delete not needed mypy exclusion for removed hf_configs files.
danielkorzekwa Mar 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ repos:
rev: v1.17.1
hooks:
- id: mypy
# Exclude HF config directories to avoid duplicate module errors (e.g., configuration_nemotron_h.py exists in multiple model configs)
exclude: "tests/gpu/torch/puzzletron/resources/hf_configs/"

- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v21.1.0
Expand Down Expand Up @@ -95,6 +97,7 @@ repos:
modelopt/torch/speculative/eagle/utils.py|
modelopt/torch/speculative/plugins/transformers.py|
modelopt/torch/utils/plugins/megatron_mmlu.py|
modelopt/torch/puzzletron/decilm/deci_lm_hf_code/transformers_.*\.py|
examples/chained_optimizations/bert_prune_distill_quantize.py|
examples/deepseek/quantize_to_nvfp4.py|
examples/deepseek/ptq.py|
Expand All @@ -113,7 +116,6 @@ repos:
examples/speculative_decoding/server_generate.py|
experimental/dms/models/qwen3/configuration_qwen3_dms.py|
experimental/dms/models/qwen3/modeling_qwen3_dms.py|
modelopt/torch/puzzletron/decilm/deci_lm_hf_code/transformers_.*\.py|
)$

# Default hook for Apache 2.0 in c/c++/cuda files
Expand Down
2 changes: 1 addition & 1 deletion modelopt/torch/puzzletron/anymodel/models/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.

# Import models to trigger factory registration
# from modelopt.torch.puzzletron.anymodel.models.gpt_oss_20b import *
from modelopt.torch.puzzletron.anymodel.models.gpt_oss import *
from modelopt.torch.puzzletron.anymodel.models.llama import *
from modelopt.torch.puzzletron.anymodel.models.mistral_small import *
from modelopt.torch.puzzletron.anymodel.models.nemotron_h import *
Expand Down
22 changes: 22 additions & 0 deletions modelopt/torch/puzzletron/anymodel/models/gpt_oss/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

"""GPT-OSS model support for AnyModel."""

from .gpt_oss_converter import GptOssConverter
from .gpt_oss_model_descriptor import GptOssModelDescriptor
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# mypy: ignore-errors

"""GPT-OSS-20B converter for AnyModel compression."""

from typing import List

from transformers import PretrainedConfig

from modelopt.torch.puzzletron.anymodel.converter import Converter, ConverterFactory
from modelopt.torch.puzzletron.decilm.deci_lm_hf_code.block_config import (
AttentionConfig,
BlockConfig,
FFNConfig,
MoEConfig,
)


@ConverterFactory.register_decorator("gpt_oss")
class GptOssConverter(Converter):
"""Converter for GPT-OSS models to AnyModel format.

GPT-OSS is a pure MoE model with 32/128 experts per layer and 4/16 active experts.
All layers use MoE FFN (no standard dense FFN layers).
"""

quantized = "mxfp4"

@staticmethod
def create_block_configs_from_main_config(config: PretrainedConfig) -> List[BlockConfig]:
"""Create block configs for GPT-OSS layers.

GPT-OSS uses MoE for all FFN layers with:
- 32/128 local experts (num_local_experts)
- 4/16 active experts per token (experts_per_token)
- No dense/standard FFN layers
"""
num_hidden_layers = config.num_hidden_layers
num_local_experts = config.num_local_experts
experts_per_token = config.experts_per_token
intermediate_size = config.intermediate_size

block_configs = []
for layer_idx in range(num_hidden_layers):
block_config = BlockConfig(
attention=AttentionConfig(
no_op=False, num_key_value_heads=config.num_key_value_heads
),
ffn=FFNConfig(
no_op=False,
intermediate_size=None, # MoE doesn't use this field
moe=MoEConfig(
num_local_experts=num_local_experts,
num_experts_per_tok=experts_per_token,
expert_intermediate_dim=intermediate_size,
),
),
).to_dict()
block_configs.append(block_config)

return block_configs
Original file line number Diff line number Diff line change
@@ -0,0 +1,236 @@
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# mypy: ignore-errors

"""GPT-OSS model descriptor for AnyModel compression."""

import re
from dataclasses import dataclass, field
from typing import Dict, List, Tuple, Type

import torch.nn as nn
from transformers.models.gpt_oss.modeling_gpt_oss import GptOssDecoderLayer, GptOssRotaryEmbedding

from modelopt.torch.puzzletron.anymodel.model_descriptor import (
ModelDescriptor,
ModelDescriptorFactory,
)
from modelopt.torch.puzzletron.anymodel.puzzformer.no_op import (
MatchingZeros,
Same,
return_tuple_of_size,
)
from modelopt.torch.puzzletron.decilm.deci_lm_hf_code.block_config import BlockConfig
from modelopt.torch.puzzletron.pruning.expert_removal_pruning_mixin import (
ExpertRemovalLayerDescriptor,
ExpertRemovalPruningMixIn,
)

# Expert removal is supported for unquantized models (test models).
# Production models use MXFP4 quantized MoE with combined tensors
# (gate_up_proj_blocks, down_proj_blocks), which is not yet supported.
from modelopt.torch.puzzletron.pruning.pruning_mixin import PruningMixIn
from modelopt.torch.puzzletron.utils.dummy_modules import DummyBlock


@ModelDescriptorFactory.register_decorator("gpt_oss")
class GptOssModelDescriptor(ModelDescriptor):
"""Model descriptor for GPT-OSS (pure MoE model)."""

_DECODER_LAYER_CLS: Type[nn.Module] = None

@classmethod
def create_dummy_block(cls, original_layer: GptOssDecoderLayer, block_index: int) -> nn.Module:
dummy_block = DummyBlock(block_index=block_index)
# Required by `GptOssModel.forward`.
dummy_block.attention_type = original_layer.attention_type
return dummy_block

@staticmethod
def decoder_layer_cls():
"""Get the decoder layer class for GPT-OSS models.

GPT-OSS is a standard transformers model in recent versions.
Import directly from transformers.models.gpt_oss.modeling_gpt_oss.
"""
return GptOssDecoderLayer

@staticmethod
def block_config_to_layer_overrides(block_config: BlockConfig):
"""Map BlockConfig to layer constructor overrides."""
override_kwargs = {}

if block_config.attention.num_key_value_heads is not None:
override_kwargs["num_key_value_heads"] = block_config.attention.num_key_value_heads

if block_config.ffn.moe is not None:
override_kwargs["moe_intermediate_size"] = block_config.ffn.moe.expert_intermediate_dim
override_kwargs["num_local_experts"] = block_config.ffn.moe.num_local_experts
override_kwargs["num_experts_per_tok"] = block_config.ffn.moe.num_experts_per_tok

return override_kwargs

@staticmethod
def attn_no_op_post_init(decoder_layer):
"""Replace attention sublayers with no-op modules."""
decoder_layer.input_layernorm = Same()
decoder_layer.self_attn = return_tuple_of_size(MatchingZeros, size=2)()

@staticmethod
def mlp_no_op_post_init(decoder_layer):
"""Replace MLP sublayers with no-op modules.

Note: GPT-OSS MoE layers return (hidden_states, router_scores), so we need
to return a tuple of 2 values.
"""
decoder_layer.post_attention_layernorm = Same()
decoder_layer.mlp = return_tuple_of_size(MatchingZeros, size=2)()

@staticmethod
def init_rotary_embedding(model, runtime):
"""Initialize rotary embeddings on the correct device."""
# GPT-OSS uses RoPE with YARN scaling

model.model.rotary_emb = GptOssRotaryEmbedding(
config=model.config,
device=runtime.device,
)

@staticmethod
def input_embedding_name():
return "model.embed_tokens"

@staticmethod
def output_embedding_name():
return "lm_head"

@staticmethod
def final_norm_name():
return "model.norm"

@staticmethod
def layer_block_name(index: int):
return f"model.layers.{index}"

@staticmethod
def layer_name_predicates(num_layers: int) -> Dict[str, re.Pattern]:
"""Define regex patterns for grouping weights into subblocks."""
layer_name_patterns = {
"embeddings": re.compile(r"^model\.embed_tokens\.weight$"),
"lm_head": re.compile(r"^(model\.norm\.weight|lm_head\.weight)$"),
}

def build_ffn_predicates() -> Dict[str, re.Pattern]:
"""FFN is MoE in GPT-OSS with MXFP4 quantization."""
return {
f"block_{layer_idx}_ffn": re.compile(
rf"^model\.layers\.{layer_idx}\."
r"(post_attention_layernorm\.weight"
r"|mlp\.router\.weight"
r"|mlp\.router\.bias"
r"|mlp\.experts\.(gate_up_proj|down_proj)(_(bias|blocks|scales))?)$"
)
for layer_idx in range(num_layers)
}

def build_attention_predicates() -> Dict[str, re.Pattern]:
return {
f"block_{layer_idx}_attention": re.compile(
rf"^model\.layers\.{layer_idx}\."
r"(input_layernorm\.weight"
r"|self_attn\.q_proj\.weight"
r"|self_attn\.q_proj\.bias"
r"|self_attn\.k_proj\.weight"
r"|self_attn\.k_proj\.bias"
r"|self_attn\.v_proj\.weight"
r"|self_attn\.v_proj\.bias"
r"|self_attn\.o_proj\.weight"
r"|self_attn\.o_proj\.bias"
r"|self_attn\.sinks)$"
)
for layer_idx in range(num_layers)
}

layer_name_patterns.update(
**build_ffn_predicates(),
**build_attention_predicates(),
)

return layer_name_patterns

@staticmethod
def pruning_mixins() -> Dict[str, PruningMixIn]:
"""Return available pruning mixins for GPT-OSS.

Note: Expert removal works for unquantized models (test models).
Production models use MXFP4 quantization which is not yet supported.
"""
return {"expert_removal": ExpertRemovalPruningMixIn(GptOssExpertRemovalLayerDescriptor())}


@dataclass
class GptOssExpertRemovalLayerDescriptor(ExpertRemovalLayerDescriptor):
"""
GPT-OSS MoE layer descriptor for expert removal.

Note: This only works for unquantized models (e.g., test models).
Production GPT-OSS models use MXFP4 quantization with fused experts
(_blocks, _scales, _bias), which requires a different approach.

Structure:
- Router: mlp.router with .weight and .bias
- Experts: mlp.experts.{idx}.{gate_up_proj,down_proj} with .weight and .bias
"""

target_name: str = "mlp"
moe_prefix_name: str = "model.layers.{layer_idx}.mlp"
expert_prefix_name: str = "experts"

# Router has both weight and bias
router_weights: List[str] = field(default_factory=lambda: ["router.weight"])
router_biases: List[str] = field(default_factory=lambda: ["router.bias"])

# Fused format: experts stored as single tensors
is_fused_experts: bool = True

# Fused format: single tensors containing all experts (test models)
fused_expert_weights: List[str] = field(
default_factory=lambda: [
"experts.gate_up_proj",
"experts.gate_up_proj_bias",
"experts.down_proj",
"experts.down_proj_bias",
]
)

# Not used for fused format, but kept for compatibility
expert_weights: List[str] = field(default_factory=lambda: ["gate_up_proj", "down_proj"])
expert_biases: List[str] = field(
default_factory=lambda: ["gate_up_proj_bias", "down_proj_bias"]
)

def get_modules_names_to_hook(self, model) -> List[Tuple[int, str]]:
target_class_name = "GptOssTopKRouter"

module_names_to_hook = []
for module_name, module in model.named_modules():
if (
module_name.endswith(self.target_name)
and module.__class__.__name__ == target_class_name
):
module_names_to_hook.append(
(self.block_idx_from_module_name(module_name), module_name)
)
return module_names_to_hook
Loading
Loading