Repository navigation
Conversation
Account for C/H/W attention using the actual hybrid pattern and real-token statistics, including compressors, indexer work, grouped output projection, and MTP overhead. Preserve the existing non-DSv4 calculations. Related to NVIDIA#5795. Adapted from NVIDIA#5142, NVIDIA#5358, and NVIDIA#5762. Signed-off-by: Deyu Fu <deyuf@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 4734000 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current HybridModel FLOPs calculation omits C/H/W attention layers. Count their query/KV/output projections, window attention, compression, ratio-4 indexer and sparse attention, and ratio-128 attention. Read layer counts and MTP depth from the actual hybrid pattern, and use DSv4's head dimension rather than an uninferred MLA argument default.
Reuse main's real-token and squared-sequence-length statistics for packed batches. Packed Top-K saturation remains an estimate based on token-weighted mean sequence length; the existing statistics do not retain individual document lengths. Keep the existing forward/backward FLOPs convention and include MTP normalization/projection work.
Related to #5795. Adapted from the DSv4 accounting in #5142, #5358, and #5762. Independent of #7336 and #7469. This changes reported FLOPs, not model execution speed.
Validation