Skip to content

Move raw multimodal Tensors to CUDA before inference request checkpoint recomp. - #6976

Merged
ericharper merged 2 commits into
NVIDIA:mainfrom
cspades:cye/mm_request_ckpt_fix
Aug 31, 2026
Merged

Move raw multimodal Tensors to CUDA before inference request checkpoint recomp.#6976
ericharper merged 2 commits into
NVIDIA:mainfrom
cspades:cye/mm_request_ckpt_fix

Conversation

@cspades

@cspades cspades commented Aug 29, 2026

Copy link
Copy Markdown
Member
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

  • Made a mistake while addressing this comment to clear out the multimodal embedding cache during engine pause where I added the recomp through the vision encoder but did not move the image tensor inputs to CUDA.
    • Mirrors what _build_vlm_request does, moving all the image tensors to CUDA before the encoder forward pass.
    • Unfortunately, since I didn't write a unit test for this feature and RL dictates whether we use this path, this bug elluded me.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

…nt recomputation.

Signed-off-by: Cory Ye <cye@nvidia.com>
@cspades cspades self-assigned this Aug 29, 2026
@cspades
cspades requested review from a team as code owners August 29, 2026 19:49
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft August 29, 2026 19:49
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Cory Ye <cye@nvidia.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Aug 31, 2026
@ericharper
ericharper enabled auto-merge August 31, 2026 18:34
@ericharper
ericharper added this pull request to the merge queue Aug 31, 2026
@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/33430573559

Merged via the queue into NVIDIA:main with commit 6b0986c Aug 31, 2026
107 of 111 checks passed
ksivaman pushed a commit to ksivaman/Megatron-LM that referenced this pull request Sep 1, 2026
…nt recomp. (NVIDIA#6976)

Signed-off-by: Cory Ye <cye@nvidia.com>
@cspades
cspades deleted the cye/mm_request_ckpt_fix branch September 6, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants