fix(inference): preserve batch invariance for Nemotron Nano - #6893
Conversation
|
/ok to test 5eb83f5 |
|
@utkarsh530 In case you need for your work. |
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
santhnm2
left a comment
There was a problem hiding this comment.
Is it possible to consolidate the new unit tests into existing files?
5eb83f5 to
1961b5e
Compare
|
/ok to test 1961b5e |
|
/claude review |
1961b5e to
a01cc0d
Compare
|
/ok to test a01cc0d |
Signed-off-by: wdykas <wdykas@nvidia.com>
a01cc0d to
c837c0a
Compare
|
/ok to test c837c0a |
|
@wdykas Thanks! This is quite helpful |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/33013279273 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/33018285931 |
Summary
This is a targeted follow-up to #6521, which introduced batch-invariant CUDA-graph token alignment and enabled the vLLM
fused-MoE backend under batch-invariant mode.
That MR intentionally pads token counts to 64-token boundaries while leaving request metadata unchanged. For Nemotron Nano, this exposed two missing cases:
TEGroupedMLPpath, breaking bitwisegeneration/training parity.
we could get rid of this and just us the version where I overwrite the Rmsnorms with our triton kernel but this is much faster. The rmsnorm is 2x slower in triton so I would like to keep this path.
Changes
The token alignment introduced by #6521 remains intact—the consumers now correctly distinguish aligned token rows from actual requests.