Skip to content

Fix missing golden values updates - #6528

Merged
janEbert merged 2 commits into
NVIDIA:mainfrom
janEbert:update-gvs
Aug 15, 2026
Merged

Fix missing golden values updates#6528
janEbert merged 2 commits into
NVIDIA:mainfrom
janEbert:update-gvs

Conversation

@janEbert

@janEbert janEbert commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

#5916 missed some GitLab-only tests, so we add the missing updates using pipelines from the exact commit that was merged.

  • I, the PR author, have personally reviewed every line of this PR.
    ^ cross-checked every number with my slide rule

Joking aside, I made sure all files updated here weren't touched between #5916 and this commit (f4dadcf). Need to make sure to update in case this isn't merged soon.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft August 14, 2026 00:12
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@janEbert
janEbert marked this pull request as ready for review August 14, 2026 00:12
NVIDIA#5916 missed some GitLab-only
tests, so we add the missing updates using a pipeline from the exact
commit that was merged.

Signed-off-by: janEbert <janpabloe@nvidia.com>
@janEbert

Copy link
Copy Markdown
Contributor Author

The nans that the lint complains about were included in the files previously and not added through these changes.

Removing NaNs from the files.

Signed-off-by: janEbert <janpabloe@nvidia.com>
@janEbert

Copy link
Copy Markdown
Contributor Author

Applied same solution as #5916.

@janEbert
janEbert added this pull request to the merge queue Aug 14, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/31810071174

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/31830296305

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/31833218608

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 14, 2026
@janEbert
janEbert added this pull request to the merge queue Aug 15, 2026
Merged via the queue into NVIDIA:main with commit e79110c Aug 15, 2026
186 checks passed
@janEbert
janEbert deleted the update-gvs branch August 15, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants