Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion megatron/core/distributed/finalize_model_grads.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,11 @@ def reset_model_temporary_tensors(config: TransformerConfig, model: List[torch.n
"""
for model_chunk in model:
for module in get_attr_wrapped_model(model_chunk, 'modules')():
if config.moe_router_enable_expert_bias and hasattr(module, 'expert_bias'):
if (
config.moe_router_enable_expert_bias
and hasattr(module, 'expert_bias')
and module.expert_bias is not None
):
module.local_tokens_per_expert.zero_()
if (
config.moe_router_load_balancing_type == "global_aux_loss"
Expand Down Expand Up @@ -351,6 +355,7 @@ def _update_router_expert_bias(
if (
hasattr(module, 'expert_bias')
and module.training
and module.expert_bias is not None
and not getattr(module, 'frozen_expert_bias', False)
):
tokens_per_expert_list.append(module.local_tokens_per_expert)
Expand Down
27 changes: 27 additions & 0 deletions megatron/core/fp8_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,29 @@ def get_fp8_context(config: TransformerConfig, layer_no: int = -1, is_init: bool

return fp8_context

def get_fp8_disabled_context(config: TransformerConfig, is_init: bool = False):
"""Return a context manager that disables TE quantization.

Use this around submodule construction or execution that must stay in a higher
precision while its enclosing module uses an FP8 or FP4 context.

Args:
config: Transformer configuration that controls quantization.
is_init: Whether to disable the parameter-initialization context instead of
the forward autocast context.

Returns:
A disabled TE quantization context when quantization is active, otherwise a
no-op context.
"""
if is_init:
if not (config.fp8_param or config.fp4_param):
return nullcontext()
return transformer_engine.pytorch.fp8_model_init(enabled=False)
if not (config.fp8 or config.fp4):
return nullcontext()
return transformer_engine.pytorch.fp8_autocast(enabled=False)

else:

def get_fp8_recipe(config: TransformerConfig):
Expand All @@ -881,6 +904,10 @@ def get_fp8_context(config: TransformerConfig, layer_no: int = -1, is_init: bool
"""Returns dummy fp8 context manager since TE is not available."""
return nullcontext()

def get_fp8_disabled_context(config: TransformerConfig, is_init: bool = False):
"""Return a no-op context manager since TE is not available."""
return nullcontext()


if HAVE_TE:
from transformer_engine.pytorch.fp8 import FP8GlobalStateManager
Expand Down
93 changes: 90 additions & 3 deletions megatron/core/fusions/fused_bias_dropout.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
# Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved.
from typing import Optional, Tuple
# Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
from typing import TYPE_CHECKING, Optional, Tuple

import torch

from megatron.core.jit import jit_fuser

if TYPE_CHECKING:
from megatron.core.tensor_parallel.random import CheckpointWithoutOutputManager

# pylint: disable=missing-function-docstring


Expand Down Expand Up @@ -80,7 +83,26 @@ def bias_dropout_add_fused_inference(
return _bias_dropout_add_func(x_with_bias, residual, prob, False)


def get_bias_dropout_add(training, fused):
def get_bias_dropout_add(
training, fused, mhc_recompute_manager: Optional['CheckpointWithoutOutputManager'] = None
):
"""
Get the bias-dropout-add function.

Args:
training: Whether in training mode.
fused: Whether to use fused implementation.
mhc_recompute_manager: Optional CheckpointWithoutOutputManager for checkpoint management.
When provided, the returned function will wrap the BDA operation with
CheckpointWithoutOutput for memory-efficient recomputation.

Returns:
A callable that performs bias-dropout-add operation.
"""
if mhc_recompute_manager is not None:
# Return a checkpointed version that handles tuple unpacking internally
return _get_checkpointed_bda(training, fused, mhc_recompute_manager)

if fused:
# jit scripting for a nn.module (with dropout) is not
# triggering the fusion kernel. For now, we use two
Expand All @@ -92,3 +114,68 @@ def get_bias_dropout_add(training, fused):
return bias_dropout_add_fused_inference
else:
return bias_dropout_add_unfused(training)


def _get_checkpointed_bda(training, fused, mhc_recompute_manager: 'CheckpointWithoutOutputManager'):
"""
Create a checkpointed bias-dropout-add function.

This function handles:
1. Tuple unpacking for x_with_bias (required because save_for_backward can't save tuples)
2. Non-tensor arguments like dropout probability (handled by CheckpointWithoutOutput)
3. Auto-registration to the CheckpointWithoutOutputManager

Args:
training: Whether in training mode.
fused: Whether to use fused implementation.
mhc_recompute_manager: CheckpointWithoutOutputManager for checkpoint management.

Returns:
A callable that performs checkpointed bias-dropout-add operation.
"""
from megatron.core.tensor_parallel.random import CheckpointWithoutOutput

# Get the underlying BDA function
if fused:
if training:
bda_func = bias_dropout_add_fused_train
else:
bda_func = bias_dropout_add_fused_inference
else:
bda_func = bias_dropout_add_unfused(training)

def _checkpointed_bda(x_with_bias, residual, prob):
"""
Checkpointed BDA that handles tuple unpacking internally.

Args:
x_with_bias: Either a tuple (x, bias) or a single tensor x.
residual: Residual tensor.
prob: Dropout probability.

Returns:
Output tensor after bias-dropout-add.
"""
# Create checkpoint with manager
ckpt = CheckpointWithoutOutput(ckpt_manager=mhc_recompute_manager)

# Handle case where x_with_bias might be a single tensor (e.g., from IdentityOp)
if isinstance(x_with_bias, tuple):
x, bias = x_with_bias
else:
x = x_with_bias
bias = None

# Wrapper function that re-packs the tuple for the actual BDA function
def _bda_wrapper(output, bias, res, dropout):
return bda_func((output, bias), res, dropout)

# Call checkpoint with unpacked arguments
result = ckpt.checkpoint(_bda_wrapper, x, bias, residual, prob)

# No-op when manager is set - manager handles all discarding uniformly
ckpt.discard_output_and_register_recompute(result)

return result

return _checkpointed_bda
Loading