Pass process groups to remaining GTP-backed layers - #6262
Merged
fanshiqing merged 1 commit intoAug 5, 2026
Merged
Conversation
Signed-off-by: ykarnati <ykarnati@nvidia.com>
fanshiqing
marked this pull request as ready for review
August 5, 2026 02:33
fanshiqing
pushed a commit
to fanshiqing/Megatron-LM
that referenced
this pull request
Aug 5, 2026
Signed-off-by: ykarnati <ykarnati@nvidia.com>
fanshiqing
pushed a commit
to fanshiqing/Megatron-LM
that referenced
this pull request
Aug 5, 2026
Signed-off-by: ykarnati <ykarnati@nvidia.com>
fanshiqing
pushed a commit
to fanshiqing/Megatron-LM
that referenced
this pull request
Aug 5, 2026
Signed-off-by: ykarnati <ykarnati@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Position embeddings and other small parameters remain replicated.
Why
#6234 adds the GTP-capable layer APIs, but these MIMO-used construction sites still supplied only TP. This completes the explicit process-group path for their dense GTP-rematerialized weights without adding MPU-global reads.
Dependency
Stacked on #6234 by @fanshiqing.
Validation