fix(multimodal): align video pixel shuffle with inference - #6255
Open
ehosseiniasl wants to merge 1 commit into
Open
fix(multimodal): align video pixel shuffle with inference#6255ehosseiniasl wants to merge 1 commit into
ehosseiniasl wants to merge 1 commit into
Conversation
Signed-off-by: Ehsan Hosseini Asl <ehsan.hosseiniasl@gmail.com>
svcnvidia-nemo-ci
marked this pull request as draft
August 4, 2026 18:59
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
This was referenced Aug 4, 2026
ehosseiniasl
marked this pull request as ready for review
August 6, 2026 16:33
6 tasks
cuichenx
approved these changes
Aug 14, 2026
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct dynamic-resolution pixel shuffling for multimodal image and temporal-video inputs.
Motivation
The policy training path must preserve the same spatial feature ordering used during inference. Flattened reshaping of non-square video frames grouped the wrong neighboring
patches, causing generation and training to consume differently ordered visual features.
This is required for consistent Nemotron Omni video GRPO training and rollout/training log-probability parity.
Validation
Related work
Megatron-Bridge: NVIDIA-NeMo/Megatron-Bridge#5304
Gym: NVIDIA-NeMo/Gym#2324