Skip to content

test(inference): mark prefix caching CUDA graph test flaky - #6131

Merged
ko3n1g merged 1 commit into
NVIDIA:mainfrom
ko3n1g:ko3n1g/test/mark-prefix-caching-cuda-graphs-flaky
Jul 29, 2026
Merged

ko3n1g merged 1 commit into
NVIDIA:mainfrom
ko3n1g:ko3n1g/test/mark-prefix-caching-cuda-graphs-flaky

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

Background / motivation

TestPrefixCachingCudaGraphs::test_prefix_caching_cuda_graphs intermittently invalidates CUDA graph capture in the dev inference unit-test bucket. The failure is independent of the triggering changes:

PR Change scope Failure evidence
#6110 NeMo Run dependency pin [decode-transformer], run 30479289096 / job 90671101491
#6049 Functional inference recipes [mixed-transformer], run 30463155293 / job 90637047921
#6120 Package-version strings [mixed-transformer], run 30427570429 / job 90655889236
#6109 Documentation only [mixed-transformer], run 30407317207 / job 90536399941

Each job reports CUBLAS_STATUS_INTERNAL_ERROR from cublasSetStream, followed by cudaErrorStreamCaptureInvalidated at capture end.

What changed

Details

The dev unit-test runner selects not flaky_in_dev, so this prevents the intermittent capture failure from blocking standard PR CI. The broader flaky marker is not added because the observed failures are all in the dev / latest job; LTS coverage remains enabled.

Fixes #6130.

Tested

  • uv sync --locked --only-group linting — completed from the locked environment.
  • BASE_REF=main CHECK_ONLY=true SKIP_DOCS=false bash tools/autoformat.sh with the linting environment on PATH — black, isort, pylint, and ruff passed; the wrapper exited 0. Its non-blocking mypy invocation was unavailable in the repository's linting-only group.
  • Parsed the test module with Python ast and verified the function decorator list includes pytest.mark.flaky_in_dev ahead of all six parametrized cases.
  • git diff --check — passed.
  • Full GPU pytest was not run locally: the available environment does not include PyTorch, and collection stops in tests/unit_tests/conftest.py with ModuleNotFoundError: torch.

Contribution pre-checks

@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g marked this pull request as ready for review July 29, 2026 19:22
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team July 29, 2026 19:22
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ko3n1g force-pushed the ko3n1g/test/mark-prefix-caching-cuda-graphs-flaky branch from 463f781 to e977864 Compare July 29, 2026 19:22
@ko3n1g
ko3n1g marked this pull request as draft July 29, 2026 19:22
@ko3n1g
ko3n1g marked this pull request as ready for review July 29, 2026 19:24
@ko3n1g
ko3n1g merged commit c7d1865 into NVIDIA:main Jul 29, 2026
35 checks passed
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>

This branch was previously deployed

2 inactive deployments
public — e977864f Deployed Jul 29, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4937
test — e977864f Deployed Jul 29, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 CI failure: tests/unit_tests/inference/engines/test_prefix_caching_cuda_graphs.py::TestPrefixCachingCudaGraphs::test_prefix_caching_cuda_graphs

1 participant