Skip to content

test(ci): AUT-1173 set functional tests to ft_launcher - #6128

Merged
ko3n1g merged 2 commits into
NVIDIA:mainfrom
svcnemo-autobot:ci/migrate-ft-launcher
Jul 30, 2026
Merged

ko3n1g merged 2 commits into
NVIDIA:mainfrom
svcnemo-autobot:ci/migrate-ft-launcher

Conversation

@svcnemo-autobot

@svcnemo-autobot svcnemo-autobot commented Jul 29, 2026 •

Copy link
Copy Markdown
Collaborator

Background

Run 30454176245 hung in the legacy torchrun path while creating NCCL communicators. Moving functional tests to ft_launcher exposed three NVRx-free tests that intentionally uninstall the package providing that command.

What changed

  • Set LAUNCHER: ft_launcher for 325 functional-test configs.
  • Retain LAUNCHER: torchrun for the three configs that uninstall nvidia-resiliency-ext.

Details

flowchart LR
    C[Functional configs] --> N{Uninstalls NVRx?}
    N -- No --> F[ft_launcher]
    N -- Yes, 3 configs --> T[torchrun]
Loading

The exceptions preserve the NVRx-free coverage and prevent ft_launcher: command not found.

Tested

  • Parsed all 328 functional configs as YAML.
  • Verified 325 select ft_launcher and exactly the three NVRx-free configs select torchrun.
  • Verified every torchrun exception uninstalls nvidia-resiliency-ext.
  • Megatron-LM lint check and git diff --check.

@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner July 29, 2026 16:55
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from ko3n1g July 29, 2026 16:55
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 29, 2026 16:56
@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 34b15bd

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@nemo-autobot-origin
nemo-autobot-origin Bot force-pushed the ci/migrate-ft-launcher branch from 34b15bd to a034449 Compare July 29, 2026 17:00
@svcnvidia-nemo-ci svcnvidia-nemo-ci changed the title test(ci): AUT-1173 migrate all tests to ft_launcher test(ci): AUT-1173 set functional tests to ft_launcher Jul 29, 2026
@ko3n1g
ko3n1g marked this pull request as ready for review July 29, 2026 17:04
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test a034449

@ko3n1g
ko3n1g disabled auto-merge July 29, 2026 19:19
@ko3n1g
ko3n1g enabled auto-merge July 29, 2026 19:20
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
auto-merge was automatically disabled July 30, 2026 02:58

Head branch was pushed to by a user without write access

@ko3n1g
ko3n1g enabled auto-merge July 30, 2026 05:36
@ko3n1g
ko3n1g added this pull request to the merge queue Jul 30, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30532161430

Merged via the queue into NVIDIA:main with commit ab16414 Jul 30, 2026
181 checks passed

This branch was previously deployed

2 inactive deployments
public — b8aaadeb Deployed Jul 30, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4970
test — b8aaadeb Deployed Jul 30, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants