Skip to content

ci: fix test notifications for weekly/release tests - #6055

Merged
balasaajay merged 2 commits into
NVIDIA:mainfrom
balasaajay:triage-integ-weekly-fix
Jul 30, 2026
Merged

balasaajay merged 2 commits into
NVIDIA:mainfrom
balasaajay:triage-integ-weekly-fix

Conversation

@balasaajay

@balasaajay balasaajay commented Jul 26, 2026 •

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Enhance test notifications for weekly/release tests into a single root notification for MR, nightly, weekly, and release pipelines. Update tests to ensure notifications are correctly delegated to the triage package without direct alerts from individual workload runners.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

…nto a single root notification for MR, nightly, weekly, and release pipelines. Update tests to ensure notifications are correctly delegated to the triage package without direct alerts from individual workload runners.

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@balasaajay
balasaajay requested a review from a team as a code owner July 26, 2026 21:17
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 26, 2026 21:17
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@balasaajay
balasaajay marked this pull request as ready for review July 27, 2026 20:14
@balasaajay balasaajay changed the title Enhance test notifications for weekly/release tests ci: fix test notifications for weekly/release tests Jul 27, 2026
@ko3n1g

ko3n1g commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

/review

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator

🤖 On it — handling this as review.

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator

🔎 On it — resolving the pull request and reviewing it rigorously.

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator

🤖 I couldn't get started on this yet — tell me a bit more (which repository, and what change) and I'll pick it up.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Jul 27, 2026
@balasaajay
balasaajay enabled auto-merge July 29, 2026 05:58
@balasaajay
balasaajay added this pull request to the merge queue Jul 29, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30426964001

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2026
@balasaajay
balasaajay added this pull request to the merge queue Jul 29, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30500754684

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30502503886

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30502652199

Merged via the queue into NVIDIA:main with commit 3f88509 Jul 30, 2026
139 of 143 checks passed
@balasaajay
balasaajay deleted the triage-integ-weekly-fix branch July 30, 2026 04:31
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>

This branch was previously deployed

2 inactive deployments
public — 379d2cee Deployed Jul 27, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4729
test — 379d2cee Deployed Jul 27, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants