Fixed dp-balanced THD packing scheduler - #5993
Draft
FDecaYed wants to merge 1 commit into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
24 tasks
Contributor
Author
|
/ok to test 0be6b6b |
FDecaYed
force-pushed
the
codex/fixed-thd-packing-scheduler
branch
from
July 23, 2026 16:07
0be6b6b to
49bd7a3
Compare
Contributor
Author
|
/ok to test 49bd7a3 |
FDecaYed
force-pushed
the
codex/fixed-thd-packing-scheduler
branch
from
July 23, 2026 16:29
49bd7a3 to
37a68b3
Compare
Contributor
Author
|
/ok to test 37a68b3 |
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
FDecaYed
force-pushed
the
codex/fixed-thd-packing-scheduler
branch
from
July 24, 2026 08:47
37a68b3 to
8040550
Compare
Contributor
Author
|
/ok to test 8040550 |
Contributor
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| data_iterator, | ||
| num_microbatches: int, | ||
| dp_group, | ||
| tp_group, |
Contributor
There was a problem hiding this comment.
Typo: "emtpy" → "empty".
Suggested change
| tp_group, | |
| # Get a batch from data_iterator or create an empty batch. |
Phlip79
marked this pull request as draft
August 10, 2026 18:59
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed dp-balanced THD packing scheduler
Summary
Add the fixed, deterministic data-parallel-balanced scheduler for packed THD
batches, including its training-loop contract and process-group forwarding.
Scope and non-goals
generation, or DSv4 model code.
Provenance
This local recut is reconstructed from the frozen
mainbaselinebb5647a9bdd0, not a replay. It references master #5795 and retains only thefixed scheduler portion of #5679. Credit goes to the original contributors of
#5679: @ilml. The DSv4 integration in #5795 is by @hxbai.
Dependencies
None beyond the frozen baseline used for this local recut. This is a reusable
prerequisite outside the nine-PR DSv4-specific series.
Tests
Publication
Publish in the first prerequisite round on then-current
main. This is not astacked-review PR.