Skip to content

Fix formatting error in qwen3_30b_a3b config - #5978

Merged
jon-barker merged 2 commits into
NVIDIA:mainfrom
jon-barker:jbarker/qwen3_30b_a3b_config_fix
Jul 23, 2026
Merged

jon-barker merged 2 commits into
NVIDIA:mainfrom
jon-barker:jbarker/qwen3_30b_a3b_config_fix

Conversation

@jon-barker

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Fix formatting error in qwen3_30b_a3b config

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Signed-off-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
@jon-barker
jon-barker requested a review from a team as a code owner July 22, 2026 21:15
@copy-pr-bot

copy-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 22, 2026 21:15
@jon-barker
jon-barker marked this pull request as ready for review July 22, 2026 21:16
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team July 22, 2026 21:16
@jon-barker
jon-barker enabled auto-merge July 22, 2026 21:16
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Jul 22, 2026
@jon-barker

Copy link
Copy Markdown
Contributor Author

/ok to test 854255a

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29982710911

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29983601629

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29988908450

Merged via the queue into NVIDIA:main with commit 6cd6ea5 Jul 23, 2026
93 checks passed
@jon-barker
jon-barker deleted the jbarker/qwen3_30b_a3b_config_fix branch July 23, 2026 10:48
shjwudp pushed a commit to shjwudp/Megatron-LM that referenced this pull request Jul 30, 2026
Signed-off-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
Co-authored-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
Co-authored-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
Co-authored-by: Jon Barker <jbarker@aws-dfw-cs-001-login-01.cm.cluster>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>

This branch was previously deployed

2 inactive deployments
public — 854255a8 Deployed Jul 22, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4309
test — 854255a8 Deployed Jul 22, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants